From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32729 invoked by alias); 6 Nov 2009 16:55:00 -0000 Received: (qmail 32720 invoked by uid 22791); 6 Nov 2009 16:54:59 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Nov 2009 16:54:55 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 4831710ECB; Fri, 6 Nov 2009 16:54:53 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id F077510EC2; Fri, 6 Nov 2009 16:54:52 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1N6S5K-0006TN-IL; Fri, 06 Nov 2009 11:54:50 -0500 Date: Fri, 06 Nov 2009 21:49:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb@sources.redhat.com Subject: Re: gdb v7.0 - user defined command's document section - space prefixed end Message-ID: <20091106165450.GA24706@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb@sources.redhat.com References: <4AE7D19A.70600@googlemail.com> <20091103143305.GN4573@adacore.com> <4AF07D60.2020305@googlemail.com> <20091103194313.GS4573@adacore.com> <20091103195130.GA19931@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00068.txt.bz2 On Fri, Nov 06, 2009 at 07:40:39PM +0300, Vladimir Prus wrote: > read_next_line already used to took process_commands parameter, and process_next_line > was nothing but "Extract Function" refactoring, so it did not change that. > > The process_commands parameter was added to read_next_line for exactly the reason > Tom suggested -- to support Python. When parsing 'python' command we need to skip > all the way to the 'end' without stripping indentation. And when not parsing 'python' > command, process_commands should be set. Therefore, here's the patch that should fix > this problem. Grep claims no other problematic places. > > OK? No. I don't think we should strip all whitespace and lines starting with "#" from documentation, or do special handling of "else", or any of the other bits enabled by parse_commands. -- Daniel Jacobowitz CodeSourcery