Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: James Pandavan <james.pandavan@googlemail.com>, gdb@sourceware.org
Subject: Re: gdb v7.0 - user defined command's document section - space  prefixed end
Date: Tue, 03 Nov 2009 19:51:00 -0000	[thread overview]
Message-ID: <20091103195130.GA19931@caradoc.them.org> (raw)
In-Reply-To: <20091103194313.GS4573@adacore.com>

On Tue, Nov 03, 2009 at 11:43:13AM -0800, Joel Brobecker wrote:
> > I noticed my scripts didn't work under v7.0 only when I saw this bug in  
> > launchpad. I guess I am not the only one who has indented "ends" this way 
> > :)
> > https://bugs.launchpad.net/ubuntu/+source/gdb/+bug/461594
> 
> If you could maybe help us a little bit, and track down the author
> of the patch that introduced the change of behavior, and then ask
> him whether the change was intended?

I believe it was:

2009-08-03  Jim Ingham  <jingham@apple.com>
            Vladimir Prus  <vladimir@codesourcery.com>

        Refactor reading of commands

        * defs.h (read_command_lines_1): Declare.
        * cli/cli-script.c (read_next_line): Only return string,
        do not process.
        (process_next_line): New, extracted from read_next_line.
        (recurse_read_control_structure): Take a function pointer to the
        read function.
        (get_command_line) Pass the read_next_line as reader function
        into recurse_read_control_structure.
        (read_command_lines_1): New, extracted from...
        (read_command_lines): ...here.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2009-11-03 19:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-28  6:12 James Pandavan
2009-11-03 14:33 ` Joel Brobecker
2009-11-03 18:58   ` James Pandavan
2009-11-03 19:43     ` Joel Brobecker
2009-11-03 19:51       ` Daniel Jacobowitz [this message]
2009-11-03 22:03         ` Jim Ingham
2009-11-06 21:42         ` Vladimir Prus
2009-11-06 21:49           ` Daniel Jacobowitz
2009-11-07  1:14             ` Vladimir Prus
2009-11-13 23:41               ` Daniel Jacobowitz
2009-11-19  7:17                 ` Vladimir Prus
2009-11-04 20:47       ` Tom Tromey
2009-11-04 21:07         ` Paul Koning
2009-11-04 21:18           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091103195130.GA19931@caradoc.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=gdb@sourceware.org \
    --cc=james.pandavan@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox