quit no longer seems to work

quit no longer seems to work

[Mark Kettenis]

I'm seeing the following testsuite regression:

help
List of classes of commands:

aliases -- Aliases of other commands
breakpoints -- Making program stop at certain points
data -- Examining data
files -- Specifying and examining files
internals -- Maintenance commands
obscure -- Obscure features
running -- Running the program
---Type <return> to continue, or q <return> to quit---PASS: gdb.base/page.exp: paged help
q
stack -- Examining the stack
status -- Status inquiries
support -- Support facilities
tracepoints -- Tracing of program execution without stopping the program
user-defined -- User-defined commands

Type "help" followed by a class name for a list of commands in that class.
Type "help all" for the list of all commands.
Type "help" followed by command name for full documentation.
---Type <return> to continue, or q <return> to quit---ERROR: Window too small.
UNRESOLVED: gdb.base/page.exp: q

where before I had:

help
List of classes of commands:

aliases -- Aliases of other commands
breakpoints -- Making program stop at certain points
data -- Examining data
files -- Specifying and examining files
internals -- Maintenance commands
obscure -- Obscure features
running -- Running the program
---Type <return> to continue, or q <return> to quit---PASS: gdb.base/page.exp: paged help
q
Quit
(gdb) PASS: gdb.base/page.exp: q

Anybody else seeing this?

Mark

Re: quit no longer seems to work

[Daniel Jacobowitz]

On Thu, Feb 08, 2007 at 11:26:51PM +0100, Mark Kettenis wrote:
> Anybody else seeing this?

:-(  I am too, and must come from Fred's quit_flag changes.  I
don't know why I didn't notice it when I diffed .sum files earlier
in the day.

-- 
Daniel Jacobowitz
CodeSourcery

Re: quit no longer seems to work

[Joel Brobecker]

> Anybody else seeing this?

Yeah, me too :-( (x86-linux).

-- 
Joel

Re: quit no longer seems to work

[Nick Roberts]

Mark Kettenis writes:
 > I'm seeing the following testsuite regression:
 > 
 > help
 > List of classes of commands:
 > 
 > aliases -- Aliases of other commands
 > breakpoints -- Making program stop at certain points
 > data -- Examining data
 > files -- Specifying and examining files
 > internals -- Maintenance commands
 > obscure -- Obscure features
 > running -- Running the program
 > ---Type <return> to continue, or q <return> to quit---PASS: gdb.base/page.exp: paged help
 > q
 > stack -- Examining the stack
 > status -- Status inquiries
 > support -- Support facilities
 > tracepoints -- Tracing of program execution without stopping the program
 > user-defined -- User-defined commands
 > 
 > Type "help" followed by a class name for a list of commands in that class.
 > Type "help all" for the list of all commands.
 > Type "help" followed by command name for full documentation.
 > ---Type <return> to continue, or q <return> to quit---ERROR: Window too small.
 > UNRESOLVED: gdb.base/page.exp: q

Does the patch below fix it? (Taken from Apple's code.)

-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** event-top.c	09 Feb 2007 08:39:22 +1300	1.49
--- event-top.c	09 Feb 2007 15:55:35 +1300	
*************** async_request_quit (gdb_client_data arg)
*** 1001,1007 ****
       the current command before we got back to the event loop.  So
       there is no reason to call quit again here. */
  
!   if (quit_flag == 0)
      return;
  
    quit ();
--- 1001,1007 ----
       the current command before we got back to the event loop.  So
       there is no reason to call quit again here. */
  
!   if (quit_flag == 0 && immediate_quit == 0)
      return;
  
    quit ();

Re: quit no longer seems to work

[Daniel Jacobowitz]

Fred, have you had a chance to look at this?

On Fri, Feb 09, 2007 at 03:57:52PM +1300, Nick Roberts wrote:
> Mark Kettenis writes:
>  > I'm seeing the following testsuite regression:
>  > 
>  > help
>  > List of classes of commands:
>  > 
>  > aliases -- Aliases of other commands
>  > breakpoints -- Making program stop at certain points
>  > data -- Examining data
>  > files -- Specifying and examining files
>  > internals -- Maintenance commands
>  > obscure -- Obscure features
>  > running -- Running the program
>  > ---Type <return> to continue, or q <return> to quit---PASS: gdb.base/page.exp: paged help
>  > q
>  > stack -- Examining the stack
>  > status -- Status inquiries
>  > support -- Support facilities
>  > tracepoints -- Tracing of program execution without stopping the program
>  > user-defined -- User-defined commands
>  > 
>  > Type "help" followed by a class name for a list of commands in that class.
>  > Type "help all" for the list of all commands.
>  > Type "help" followed by command name for full documentation.
>  > ---Type <return> to continue, or q <return> to quit---ERROR: Window too small.
>  > UNRESOLVED: gdb.base/page.exp: q
> 
> Does the patch below fix it? (Taken from Apple's code.)
> 
> -- 
> Nick                                           http://www.inet.net.nz/~nickrob
> 
> 
> *** event-top.c	09 Feb 2007 08:39:22 +1300	1.49
> --- event-top.c	09 Feb 2007 15:55:35 +1300	
> *************** async_request_quit (gdb_client_data arg)
> *** 1001,1007 ****
>        the current command before we got back to the event loop.  So
>        there is no reason to call quit again here. */
>   
> !   if (quit_flag == 0)
>       return;
>   
>     quit ();
> --- 1001,1007 ----
>        the current command before we got back to the event loop.  So
>        there is no reason to call quit again here. */
>   
> !   if (quit_flag == 0 && immediate_quit == 0)
>       return;
>   
>     quit ();
> 

-- 
Daniel Jacobowitz
CodeSourcery

Re: quit no longer seems to work

[Fred Fish]

On Friday 09 February 2007 09:53, Daniel Jacobowitz wrote:
> Fred, have you had a chance to look at this?

This is the first I've seen of it.

I have some errands to run this morning so will be out of the office
for several hours starting in a few minutes.  I'll look at it this
afternoon, unless someone else checks in a fix first.

-Fred

Re: quit no longer seems to work

[Fred Fish]

On Friday 09 February 2007 09:53, Daniel Jacobowitz wrote:
> Fred, have you had a chance to look at this?
> > Mark Kettenis writes:
> > ...
> > !   if (quit_flag == 0 && immediate_quit == 0)

OK, I verified that the first patch does cause gdb testsuite
regressions and the suggested patch does resolve them.  I just checked
in a patch that is equivalent to the suggested patch, but a little
cleaner I believe.

-Fred

Re: quit no longer seems to work

[Daniel Jacobowitz]

On Fri, Feb 09, 2007 at 04:48:36PM -0700, Fred Fish wrote:
> On Friday 09 February 2007 09:53, Daniel Jacobowitz wrote:
> > Fred, have you had a chance to look at this?
> > > Mark Kettenis writes:
> > > ...
> > > !   if (quit_flag == 0 && immediate_quit == 0)
> 
> OK, I verified that the first patch does cause gdb testsuite
> regressions and the suggested patch does resolve them.  I just checked
> in a patch that is equivalent to the suggested patch, but a little
> cleaner I believe.

In that case, could you please post the patch you committed to
gdb-patches?  Thanks.

-- 
Daniel Jacobowitz
CodeSourcery