From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-27673-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 2598 invoked by alias); 9 Feb 2007 16:53:30 -0000
Received: (qmail 2590 invoked by uid 22791); 9 Feb 2007 16:53:30 -0000
X-Spam-Check-By: sourceware.org
Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17)     by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 09 Feb 2007 16:53:19 +0000
Received: from drow by nevyn.them.org with local (Exim 4.63) 	(envelope-from <drow@nevyn.them.org>) 	id 1HFYzi-00048a-R2; Fri, 09 Feb 2007 11:53:06 -0500
Date: Fri, 09 Feb 2007 16:53:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>, Fred Fish <fnf@specifix.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb@sourceware.org
Subject: Re: quit no longer seems to work
Message-ID: <20070209165306.GA15875@nevyn.them.org>
Mail-Followup-To: Nick Roberts <nickrob@snap.net.nz>, 	Fred Fish <fnf@specifix.com>, 	Mark Kettenis <mark.kettenis@xs4all.nl>, gdb@sourceware.org
References: <200702082226.l18MQo4f013474@brahms.sibelius.xs4all.nl> <17867.58160.575337.645831@kahikatea.snap.net.nz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <17867.58160.575337.645831@kahikatea.snap.net.nz>
User-Agent: Mutt/1.5.13 (2006-08-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2007-02/txt/msg00057.txt.bz2

Fred, have you had a chance to look at this?

On Fri, Feb 09, 2007 at 03:57:52PM +1300, Nick Roberts wrote:
> Mark Kettenis writes:
>  > I'm seeing the following testsuite regression:
>  > 
>  > help
>  > List of classes of commands:
>  > 
>  > aliases -- Aliases of other commands
>  > breakpoints -- Making program stop at certain points
>  > data -- Examining data
>  > files -- Specifying and examining files
>  > internals -- Maintenance commands
>  > obscure -- Obscure features
>  > running -- Running the program
>  > ---Type <return> to continue, or q <return> to quit---PASS: gdb.base/page.exp: paged help
>  > q
>  > stack -- Examining the stack
>  > status -- Status inquiries
>  > support -- Support facilities
>  > tracepoints -- Tracing of program execution without stopping the program
>  > user-defined -- User-defined commands
>  > 
>  > Type "help" followed by a class name for a list of commands in that class.
>  > Type "help all" for the list of all commands.
>  > Type "help" followed by command name for full documentation.
>  > ---Type <return> to continue, or q <return> to quit---ERROR: Window too small.
>  > UNRESOLVED: gdb.base/page.exp: q
> 
> Does the patch below fix it? (Taken from Apple's code.)
> 
> -- 
> Nick                                           http://www.inet.net.nz/~nickrob
> 
> 
> *** event-top.c	09 Feb 2007 08:39:22 +1300	1.49
> --- event-top.c	09 Feb 2007 15:55:35 +1300	
> *************** async_request_quit (gdb_client_data arg)
> *** 1001,1007 ****
>        the current command before we got back to the event loop.  So
>        there is no reason to call quit again here. */
>   
> !   if (quit_flag == 0)
>       return;
>   
>     quit ();
> --- 1001,1007 ----
>        the current command before we got back to the event loop.  So
>        there is no reason to call quit again here. */
>   
> !   if (quit_flag == 0 && immediate_quit == 0)
>       return;
>   
>     quit ();
> 

-- 
Daniel Jacobowitz
CodeSourcery