From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-27668-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 30356 invoked by alias); 9 Feb 2007 02:58:08 -0000
Received: (qmail 30338 invoked by uid 22791); 9 Feb 2007 02:58:07 -0000
X-Spam-Check-By: sourceware.org
Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Feb 2007 02:57:59 +0000
Received: from kahikatea.snap.net.nz (145.62.255.123.dynamic.snap.net.nz [123.255.62.145]) 	by viper.snap.net.nz (Postfix) with ESMTP id BEAC83DACE9; 	Fri,  9 Feb 2007 15:57:56 +1300 (NZDT)
Received: by kahikatea.snap.net.nz (Postfix, from userid 500) 	id EF64D4F704; Fri,  9 Feb 2007 15:57:54 +1300 (NZDT)
From: Nick Roberts <nickrob@snap.net.nz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <17867.58160.575337.645831@kahikatea.snap.net.nz>
Date: Fri, 09 Feb 2007 02:58:00 -0000
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb@sourceware.org
Subject: Re: quit no longer seems to work
In-Reply-To: <200702082226.l18MQo4f013474@brahms.sibelius.xs4all.nl>
References: <200702082226.l18MQo4f013474@brahms.sibelius.xs4all.nl>
X-Mailer: VM 7.19 under Emacs 22.0.93.8
X-IsSubscribed: yes
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2007-02/txt/msg00052.txt.bz2

Mark Kettenis writes:
 > I'm seeing the following testsuite regression:
 > 
 > help
 > List of classes of commands:
 > 
 > aliases -- Aliases of other commands
 > breakpoints -- Making program stop at certain points
 > data -- Examining data
 > files -- Specifying and examining files
 > internals -- Maintenance commands
 > obscure -- Obscure features
 > running -- Running the program
 > ---Type <return> to continue, or q <return> to quit---PASS: gdb.base/page.exp: paged help
 > q
 > stack -- Examining the stack
 > status -- Status inquiries
 > support -- Support facilities
 > tracepoints -- Tracing of program execution without stopping the program
 > user-defined -- User-defined commands
 > 
 > Type "help" followed by a class name for a list of commands in that class.
 > Type "help all" for the list of all commands.
 > Type "help" followed by command name for full documentation.
 > ---Type <return> to continue, or q <return> to quit---ERROR: Window too small.
 > UNRESOLVED: gdb.base/page.exp: q

Does the patch below fix it? (Taken from Apple's code.)

-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** event-top.c	09 Feb 2007 08:39:22 +1300	1.49
--- event-top.c	09 Feb 2007 15:55:35 +1300	
*************** async_request_quit (gdb_client_data arg)
*** 1001,1007 ****
       the current command before we got back to the event loop.  So
       there is no reason to call quit again here. */
  
!   if (quit_flag == 0)
      return;
  
    quit ();
--- 1001,1007 ----
       the current command before we got back to the event loop.  So
       there is no reason to call quit again here. */
  
!   if (quit_flag == 0 && immediate_quit == 0)
      return;
  
    quit ();