Re: quit no longer seems to work

[Nick Roberts <nickrob@snap.net.nz>]

Mark Kettenis writes:
 > I'm seeing the following testsuite regression:
 > 
 > help
 > List of classes of commands:
 > 
 > aliases -- Aliases of other commands
 > breakpoints -- Making program stop at certain points
 > data -- Examining data
 > files -- Specifying and examining files
 > internals -- Maintenance commands
 > obscure -- Obscure features
 > running -- Running the program
 > ---Type <return> to continue, or q <return> to quit---PASS: gdb.base/page.exp: paged help
 > q
 > stack -- Examining the stack
 > status -- Status inquiries
 > support -- Support facilities
 > tracepoints -- Tracing of program execution without stopping the program
 > user-defined -- User-defined commands
 > 
 > Type "help" followed by a class name for a list of commands in that class.
 > Type "help all" for the list of all commands.
 > Type "help" followed by command name for full documentation.
 > ---Type <return> to continue, or q <return> to quit---ERROR: Window too small.
 > UNRESOLVED: gdb.base/page.exp: q

Does the patch below fix it? (Taken from Apple's code.)

-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** event-top.c	09 Feb 2007 08:39:22 +1300	1.49
--- event-top.c	09 Feb 2007 15:55:35 +1300	
*************** async_request_quit (gdb_client_data arg)
*** 1001,1007 ****
       the current command before we got back to the event loop.  So
       there is no reason to call quit again here. */
  
!   if (quit_flag == 0)
      return;
  
    quit ();
--- 1001,1007 ----
       the current command before we got back to the event loop.  So
       there is no reason to call quit again here. */
  
!   if (quit_flag == 0 && immediate_quit == 0)
      return;
  
    quit ();