Bogus change to gdb.base/cursal.exp?

Bogus change to gdb.base/cursal.exp?

[Mark Kettenis]

Nathan,

The gdb.base/cursal.exp test is currently failing for me:


Running ../../../../src/gdb/gdb/testsuite/gdb.base/cursal.exp ...
PASS: gdb.base/cursal.exp: set listsize 1
PASS: gdb.base/cursal.exp: list before run
ERROR: tcl error sourcing ../../../../src/gdb/gdb/testsuite/gdb.base/cursal.exp.
ERROR: wrong # args: should be "gdb_load arg"
    while executing
"gdb_load"
    (file "../../../../src/gdb/gdb/testsuite/gdb.base/cursal.exp" line 45)
    invoked from within
"source ../../../../src/gdb/gdb/testsuite/gdb.base/cursal.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source ../../../../src/gdb/gdb/testsuite/gdb.base/cursal.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""
Running ../../../../src/gdb/gdb/testsuite/gdb.base/cvexpr.exp ...


Looking at these error messages, your last change to
gdb.base/cursal.exp:

2006-07-24  Nathan Sidwell  <nathan@codesourcery.com>

	* gdb.base/auxv.exp: Skip on non-linux, non-solaris targets.
	* gdb.base/cursal.exp: Use gdb_file_cmd first, then separate gdb_load.

just can't be right.  Can you please back the gdb.base/cursal.exp bit out?

Thanks,

Mark

Re: Bogus change to gdb.base/cursal.exp?

[Daniel Jacobowitz]

On Wed, Aug 02, 2006 at 12:38:18AM +0200, Mark Kettenis wrote:
> Looking at these error messages, your last change to
> gdb.base/cursal.exp:
> 
> 2006-07-24  Nathan Sidwell  <nathan@codesourcery.com>
> 
> 	* gdb.base/auxv.exp: Skip on non-linux, non-solaris targets.
> 	* gdb.base/cursal.exp: Use gdb_file_cmd first, then separate gdb_load.
> 
> just can't be right.  Can you please back the gdb.base/cursal.exp bit out?

I thought Nathan had fixed this on HEAD, but I guess he didn't check in
the fix.  I've taken care of this with the attached patch, from
gdb-csl-20060226-branch.

-- 
Daniel Jacobowitz
CodeSourcery

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.1244
diff -u -p -r1.1244 ChangeLog
--- ChangeLog	25 Jul 2006 04:24:50 -0000	1.1244
+++ ChangeLog	1 Aug 2006 22:57:07 -0000
@@ -1,3 +1,7 @@
+2006-08-01  Nathan Sidwell  <nathan@codesourcery.com>
+
+	* gdb.base/cursal.exp: Add "" to gdb_load call.
+
 2006-07-25  Daniel Jacobowitz  <dan@codesourcery.com>
 
 	* gdb.cp/userdef.cc, gdb.cp/userdef.exp: New tests for unary
Index: gdb.base/cursal.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/cursal.exp,v
retrieving revision 1.2
diff -u -p -r1.2 cursal.exp
--- gdb.base/cursal.exp	24 Jul 2006 14:20:50 -0000	1.2
+++ gdb.base/cursal.exp	1 Aug 2006 22:57:07 -0000
@@ -42,7 +42,7 @@ gdb_test "set listsize 1" \
 gdb_test "list" \
     "v0 = 0;" \
     "list before run"
-gdb_load
+gdb_load ""
 if {! [runto_main]} {
     return -1
 }

Re: Bogus change to gdb.base/cursal.exp?

[Nathan Sidwell]

Daniel Jacobowitz wrote:

> I thought Nathan had fixed this on HEAD, but I guess he didn't check in
> the fix.  I've taken care of this with the attached patch, from
> gdb-csl-20060226-branch.

thanks, it fell off my todo list.

nathan

-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk

Re: Bogus change to gdb.base/cursal.exp?

[Mark Kettenis]

> Date: Tue, 1 Aug 2006 18:58:22 -0400
> From: Daniel Jacobowitz <drow@false.org>
> 
> On Wed, Aug 02, 2006 at 12:38:18AM +0200, Mark Kettenis wrote:
> > Looking at these error messages, your last change to
> > gdb.base/cursal.exp:
> > 
> > 2006-07-24  Nathan Sidwell  <nathan@codesourcery.com>
> > 
> > 	* gdb.base/auxv.exp: Skip on non-linux, non-solaris targets.
> > 	* gdb.base/cursal.exp: Use gdb_file_cmd first, then separate gdb_load.
> > 
> > just can't be right.  Can you please back the gdb.base/cursal.exp bit out?
> 
> I thought Nathan had fixed this on HEAD, but I guess he didn't check in
> the fix.  I've taken care of this with the attached patch, from
> gdb-csl-20060226-branch.

> 2006-08-01  Nathan Sidwell  <nathan@codesourcery.com>
> 
> 	* gdb.base/cursal.exp: Add "" to gdb_load call.
> 

Sorry guys, but this still doesn't work on a native GDB:

Running ../../../../src/gdb/gdb/testsuite/gdb.base/cursal.exp ...
ERROR: couldn't load  into /home/kettenis/obj/gdb/gdb/testsuite/../../gdb/gdb (timed out).

So I repeat my request; would you be so kind to back this out until
you've found a solution that doesn't break this test on a native GDB?

Mark

Re: Bogus change to gdb.base/cursal.exp?

[Daniel Jacobowitz]

On Wed, Aug 02, 2006 at 11:17:04PM +0200, Mark Kettenis wrote:
> Sorry guys, but this still doesn't work on a native GDB:
> 
> Running ../../../../src/gdb/gdb/testsuite/gdb.base/cursal.exp ...
> ERROR: couldn't load  into /home/kettenis/obj/gdb/gdb/testsuite/../../gdb/gdb (timed out).
> 
> So I repeat my request; would you be so kind to back this out until
> you've found a solution that doesn't break this test on a native GDB?

I'm really sorry about this, Mark.  I thought I tested that last one on
native GDB too.

I spent a little while looking at "fixing" the various load procedures
on the assumption that gdb_load "" ought to do something consistent,
but it's really not worth it.

I've tested and committed this much less complicated fix, which works
in every case I could throw at it.

-- 
Daniel Jacobowitz
CodeSourcery

2006-08-02  Daniel Jacobowitz  <dan@codesourcery.com>

	* cursal.exp: Pass binfile to gdb_load.

Index: gdb.base/cursal.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/cursal.exp,v
retrieving revision 1.3
diff -u -p -r1.3 cursal.exp
--- gdb.base/cursal.exp	1 Aug 2006 22:57:49 -0000	1.3
+++ gdb.base/cursal.exp	2 Aug 2006 22:29:21 -0000
@@ -42,7 +42,8 @@ gdb_test "set listsize 1" \
 gdb_test "list" \
     "v0 = 0;" \
     "list before run"
-gdb_load ""
+
+gdb_load ${binfile}
 if {! [runto_main]} {
     return -1
 }