Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: nathan@codesourcery.com, gdb@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Bogus change to gdb.base/cursal.exp?
Date: Wed, 02 Aug 2006 22:30:00 -0000	[thread overview]
Message-ID: <20060802223051.GA1048@nevyn.them.org> (raw)
In-Reply-To: <200608022117.k72LH4eR004504@elgar.sibelius.xs4all.nl>

On Wed, Aug 02, 2006 at 11:17:04PM +0200, Mark Kettenis wrote:
> Sorry guys, but this still doesn't work on a native GDB:
> 
> Running ../../../../src/gdb/gdb/testsuite/gdb.base/cursal.exp ...
> ERROR: couldn't load  into /home/kettenis/obj/gdb/gdb/testsuite/../../gdb/gdb (timed out).
> 
> So I repeat my request; would you be so kind to back this out until
> you've found a solution that doesn't break this test on a native GDB?

I'm really sorry about this, Mark.  I thought I tested that last one on
native GDB too.

I spent a little while looking at "fixing" the various load procedures
on the assumption that gdb_load "" ought to do something consistent,
but it's really not worth it.

I've tested and committed this much less complicated fix, which works
in every case I could throw at it.

-- 
Daniel Jacobowitz
CodeSourcery

2006-08-02  Daniel Jacobowitz  <dan@codesourcery.com>

	* cursal.exp: Pass binfile to gdb_load.

Index: gdb.base/cursal.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/cursal.exp,v
retrieving revision 1.3
diff -u -p -r1.3 cursal.exp
--- gdb.base/cursal.exp	1 Aug 2006 22:57:49 -0000	1.3
+++ gdb.base/cursal.exp	2 Aug 2006 22:29:21 -0000
@@ -42,7 +42,8 @@ gdb_test "set listsize 1" \
 gdb_test "list" \
     "v0 = 0;" \
     "list before run"
-gdb_load ""
+
+gdb_load ${binfile}
 if {! [runto_main]} {
     return -1
 }


      reply	other threads:[~2006-08-02 22:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-01 22:40 Mark Kettenis
2006-08-01 22:58 ` Daniel Jacobowitz
2006-08-02  9:00   ` Nathan Sidwell
2006-08-02 21:19   ` Mark Kettenis
2006-08-02 22:30     ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060802223051.GA1048@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=gdb@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=nathan@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox