Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: nathan@codesourcery.com, gdb@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Bogus change to gdb.base/cursal.exp?
Date: Tue, 01 Aug 2006 22:58:00 -0000	[thread overview]
Message-ID: <20060801225822.GA26808@nevyn.them.org> (raw)
In-Reply-To: <200608012238.k71McI5N001797@elgar.sibelius.xs4all.nl>

On Wed, Aug 02, 2006 at 12:38:18AM +0200, Mark Kettenis wrote:
> Looking at these error messages, your last change to
> gdb.base/cursal.exp:
> 
> 2006-07-24  Nathan Sidwell  <nathan@codesourcery.com>
> 
> 	* gdb.base/auxv.exp: Skip on non-linux, non-solaris targets.
> 	* gdb.base/cursal.exp: Use gdb_file_cmd first, then separate gdb_load.
> 
> just can't be right.  Can you please back the gdb.base/cursal.exp bit out?

I thought Nathan had fixed this on HEAD, but I guess he didn't check in
the fix.  I've taken care of this with the attached patch, from
gdb-csl-20060226-branch.

-- 
Daniel Jacobowitz
CodeSourcery

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.1244
diff -u -p -r1.1244 ChangeLog
--- ChangeLog	25 Jul 2006 04:24:50 -0000	1.1244
+++ ChangeLog	1 Aug 2006 22:57:07 -0000
@@ -1,3 +1,7 @@
+2006-08-01  Nathan Sidwell  <nathan@codesourcery.com>
+
+	* gdb.base/cursal.exp: Add "" to gdb_load call.
+
 2006-07-25  Daniel Jacobowitz  <dan@codesourcery.com>
 
 	* gdb.cp/userdef.cc, gdb.cp/userdef.exp: New tests for unary
Index: gdb.base/cursal.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/cursal.exp,v
retrieving revision 1.2
diff -u -p -r1.2 cursal.exp
--- gdb.base/cursal.exp	24 Jul 2006 14:20:50 -0000	1.2
+++ gdb.base/cursal.exp	1 Aug 2006 22:57:07 -0000
@@ -42,7 +42,7 @@ gdb_test "set listsize 1" \
 gdb_test "list" \
     "v0 = 0;" \
     "list before run"
-gdb_load
+gdb_load ""
 if {! [runto_main]} {
     return -1
 }


  reply	other threads:[~2006-08-01 22:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-01 22:40 Mark Kettenis
2006-08-01 22:58 ` Daniel Jacobowitz [this message]
2006-08-02  9:00   ` Nathan Sidwell
2006-08-02 21:19   ` Mark Kettenis
2006-08-02 22:30     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060801225822.GA26808@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=gdb@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=nathan@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox