Re: Bogus change to gdb.base/cursal.exp?

Daniel Jacobowitz
2006-08-02T22:30:59Z

On Wed, Aug 02, 2006 at 11:17:04PM +0200, Mark Kettenis wrote:
> Sorry guys, but this still doesn't work on a native GDB:
>
> Running ../../../../src/gdb/gdb/testsuite/gdb.base/cursal.exp ...
> ERROR: couldn't load into /home/kettenis/obj/gdb/gdb/testsuite/../../gdb/gdb (timed out).
>
> So I repeat my request; would you be so kind to back this out until
> you've found a solution that doesn't break this test on a native GDB?

I'm really sorry about this, Mark. I thought I tested that last one on
native GDB too.

I spent a little while looking at "fixing" the various load procedures
on the assumption that gdb_load "" ought to do something consistent,
but it's really not worth it.

I've tested and committed this much less complicated fix, which works
in every case I could throw at it.

--
Daniel Jacobowitz
CodeSourcery

2006-08-02 Daniel Jacobowitz <dan@codesourcery.com>

* cursal.exp: Pass binfile to gdb_load.

Index: gdb.base/cursal.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/cursal.exp,v
retrieving revision 1.3
diff -u -p -r1.3 cursal.exp
--- gdb.base/cursal.exp 1 Aug 2006 22:57:49 -0000 1.3
+++ gdb.base/cursal.exp 2 Aug 2006 22:29:21 -0000
@@ -42,7 +42,8 @@ gdb_test "set listsize 1" \
gdb_test "list" \
"v0 = 0;" \
"list before run"
-gdb_load ""
+
+gdb_load ${binfile}
if {! [runto_main]} {
return -1
}