Re: GDB 6.5 branch on Sun May 14th

Re: GDB 6.5 branch on Sun May 14th

[Nick Roberts]

[Sorry I seem to have lost the original message.  It's archived
at http://sourceware.org/ml/gdb/2006-05/msg00197.html]

> On Tue, May 16, 2006 at 09:22:15AM +1200, Nick Roberts wrote:
> > OK, I had thoght you considered the change to be reasonable.  Lets leave it
> > till after the release then, when we can discuss how to print values more
> > fully.  As Eli points out, its pretty pointless trying to predict Emacs's
> > release anyway.

> I'll get to it before the release if I can; it's just that GDB builds
> up such a backlog of unreviewed patches that it takes a full day or
> more every time I get started.

Emacs *might* be up for pretest shortly.  Can you please review/approve this
change shortly so that I can make the associated changes to Emacs?  A statement
that you will allow such a change before the next release (6.6?) of GDB would
be sufficient.

I submitted something for the testsuite earlier:
Re: [PATCH]: MI -var-set-format (Tue, 16 May 2006 14:34:42 +1200)
[http://sourceware.org/ml/gdb-patches/2006-05/msg00348.html]


-- 
Nick                                           http://www.inet.net.nz/~nickrob



2006-05-02  Nick Roberts  <nickrob@snap.net.nz>

	* mi/mi-cmd-var.c (mi_cmd_var_set_format): Add value field to output.



*** mi-cmd-var.c	31 Mar 2006 12:46:48 +1200	1.23
--- mi-cmd-var.c	02 May 2006 18:16:39 +1200	
***************
*** 211,216 ****
--- 211,219 ----
  
    /* Report the new current format */
    ui_out_field_string (uiout, "format", varobj_format_string[(int) format]);
+ 
+   /* Report the value in the new format */
+   ui_out_field_string (uiout, "value", varobj_get_value (var));
    return MI_CMD_DONE;
  }

GDB 6.5 branch on Sun May 14th

[Joel Brobecker]

Hello,

Now that the last couple of patches I thought were important enough to
delay 6.5 are in, I was thinking that maybe tomorrow would be a good
day to use as the start of the 6.5 branch. Any better suggestion?

Thanks,
-- 
Joel

Re: GDB 6.5 branch on Sun May 14th

[Nick Roberts]

 > Now that the last couple of patches I thought were important enough to
 > delay 6.5 are in, I was thinking that maybe tomorrow would be a good
 > day to use as the start of the 6.5 branch. Any better suggestion?

Could I sneak in the change to -var-set-format that I submitted earlier?
(reproduced below).  There must be a chance that Emacs 22 will be released
before the GDB release after 6.5, and then I'll be up and running.

-- 
Nick                                           http://www.inet.net.nz/~nickrob



2006-05-02  Nick Roberts  <nickrob@snap.net.nz>

	* mi/mi-cmd-var.c (mi_cmd_var_set_format): Add value field to output.



*** mi-cmd-var.c	31 Mar 2006 12:46:48 +1200	1.23
--- mi-cmd-var.c	02 May 2006 18:16:39 +1200	
***************
*** 211,216 ****
--- 211,219 ----
  
    /* Report the new current format */
    ui_out_field_string (uiout, "format", varobj_format_string[(int) format]);
+ 
+   /* Report the value in the new format */
+   ui_out_field_string (uiout, "value", varobj_get_value (var));
    return MI_CMD_DONE;
  }

Re: GDB 6.5 branch on Sun May 14th

[Joel Brobecker]

>  > Now that the last couple of patches I thought were important enough to
>  > delay 6.5 are in, I was thinking that maybe tomorrow would be a good
>  > day to use as the start of the 6.5 branch. Any better suggestion?
> 
> Could I sneak in the change to -var-set-format that I submitted earlier?
> (reproduced below).  There must be a chance that Emacs 22 will be released
> before the GDB release after 6.5, and then I'll be up and running.

I am not opposed, but remember that you can always port this change
to the branch if the patch is deemed safe enough but is committed
too late.

-- 
Joel

Re: GDB 6.5 branch on Sun May 14th

[Daniel Jacobowitz]

On Sat, May 13, 2006 at 11:57:32PM -0700, Joel Brobecker wrote:
> >  > Now that the last couple of patches I thought were important enough to
> >  > delay 6.5 are in, I was thinking that maybe tomorrow would be a good
> >  > day to use as the start of the 6.5 branch. Any better suggestion?
> > 
> > Could I sneak in the change to -var-set-format that I submitted earlier?
> > (reproduced below).  There must be a chance that Emacs 22 will be released
> > before the GDB release after 6.5, and then I'll be up and running.
> 
> I am not opposed, but remember that you can always port this change
> to the branch if the patch is deemed safe enough but is committed
> too late.

Yes, that's a better idea.  Nick, I will respond to your questions
when I have another spare day to review GDB patches, but please
remember that I objected to the patch; some of your responses to not
make sense to me.

-- 
Daniel Jacobowitz
CodeSourcery

Re: GDB 6.5 branch on Sun May 14th

[Nick Roberts]

 > > I am not opposed, but remember that you can always port this change
 > > to the branch if the patch is deemed safe enough but is committed
 > > too late.
 > 
 > Yes, that's a better idea.  Nick, I will respond to your questions
 > when I have another spare day to review GDB patches, but please
 > remember that I objected to the patch; some of your responses to not
 > make sense to me.

OK, I had thoght you considered the change to be reasonable.  Lets leave it
till after the release then, when we can discuss how to print values more
fully.  As Eli points out, its pretty pointless trying to predict Emacs's
release anyway.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: GDB 6.5 branch on Sun May 14th

[Daniel Jacobowitz]

On Tue, May 16, 2006 at 09:22:15AM +1200, Nick Roberts wrote:
> OK, I had thoght you considered the change to be reasonable.  Lets leave it
> till after the release then, when we can discuss how to print values more
> fully.  As Eli points out, its pretty pointless trying to predict Emacs's
> release anyway.

I'll get to it before the release if I can; it's just that GDB builds
up such a backlog of unreviewed patches that it takes a full day or
more every time I get started.

-- 
Daniel Jacobowitz
CodeSourcery

Re: GDB 6.5 branch on Sun May 14th

[Eli Zaretskii]

> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Sun, 14 May 2006 17:33:58 +1200
> Cc: gdb@sources.redhat.com
> 
> There must be a chance that Emacs 22 will be released before the GDB
> release after 6.5

Keep dreaming...  (Not that I'm opposed to get this patch in, if
others don't object).

Re: GDB 6.5 branch on Sun May 14th

[Daniel Jacobowitz]

On Sat, May 13, 2006 at 10:01:07PM -0700, Joel Brobecker wrote:
> Hello,
> 
> Now that the last couple of patches I thought were important enough to
> delay 6.5 are in, I was thinking that maybe tomorrow would be a good
> day to use as the start of the 6.5 branch. Any better suggestion?

Sounds good to me.  I have only one more thing tentatively planned
for 6.5 (renaming qPart:auxv to not conflict with qP) and it's not
heartbreaking if it doesn't get done.

-- 
Daniel Jacobowitz
CodeSourcery