Re: gdb testsuite Makefile.in issue

Re: gdb testsuite Makefile.in issue

[Daniel Jacobowitz]

On Wed, Feb 28, 2007 at 03:32:29PM -0800, Michael Snyder wrote:
> Folks, 
> 
> The following line has frequently caused me problems:
> 
>       t='$(program_transform_name)'; echo runtest | sed -e '' $$t; \
> 
> I think you do not run into it if you have dejagnu in your
> source tree, or if your host == target.  But if those conditions
> are not met, this line bombs.
> 
> My shell script foo is not strong, but I believe it should be
> "sed -e '$$t';", not "sed -e '' $$t'"
> 
> Yes?  No?

Why should it be any of those?  It's just runtest, not
$target-runtest.  The line gets overridden anyway if you run make
check up a directory, I imagine that's why I never see it.

Anyway, gcc uses:

AR_FOR_TARGET := $(shell \
  if [ -f $(objdir)/../binutils/ar ] ; then \
    echo $(objdir)/../binutils/ar ; \
  else \
    if [ "$(host)" = "$(target)" ] ; then \
      echo $(AR); \
    else \
       t='$(program_transform_name)'; echo ar | sed -e $$t ; \
    fi; \
  fi)

So I would imagine that removing the '' is all it takes.  Or maybe
those are wrong too, I don't think they get used much.

-- 
Daniel Jacobowitz
CodeSourcery

Re: gdb testsuite Makefile.in issue

[Michael Snyder]

On Wed, 2007-02-28 at 19:00 -0500, Daniel Jacobowitz wrote:
> On Wed, Feb 28, 2007 at 03:32:29PM -0800, Michael Snyder wrote:
> > Folks, 
> > 
> > The following line has frequently caused me problems:
> > 
> >       t='$(program_transform_name)'; echo runtest | sed -e '' $$t; \
> > 
> > I think you do not run into it if you have dejagnu in your
> > source tree, or if your host == target.  But if those conditions
> > are not met, this line bombs.
> > 
> > My shell script foo is not strong, but I believe it should be
> > "sed -e '$$t';", not "sed -e '' $$t'"
> > 
> > Yes?  No?
> 
> Why should it be any of those?  It's just runtest, not
> $target-runtest.  The line gets overridden anyway if you run make
> check up a directory, I imagine that's why I never see it.
> 
> Anyway, gcc uses:
> 
> AR_FOR_TARGET := $(shell \
>   if [ -f $(objdir)/../binutils/ar ] ; then \
>     echo $(objdir)/../binutils/ar ; \
>   else \
>     if [ "$(host)" = "$(target)" ] ; then \
>       echo $(AR); \
>     else \
>        t='$(program_transform_name)'; echo ar | sed -e $$t ; \
>     fi; \
>   fi)
> 
> So I would imagine that removing the '' is all it takes.  Or maybe
> those are wrong too, I don't think they get used much.

In point of fact, what I've been doing for years now 
is to just remove them.

Do we agree that they're wrong as they are?
Let's get rid of them...

Re: gdb testsuite Makefile.in issue

[Daniel Jacobowitz]

On Thu, Mar 01, 2007 at 11:27:31AM -0800, Michael Snyder wrote:
> Do we agree that they're wrong as they are?
> Let's get rid of them...

Fine with me, or get rid of $RUNTEST_FOR_TARGET entirely and just use $RUNTEST.

-- 
Daniel Jacobowitz
CodeSourcery