From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-27948-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 22390 invoked by alias); 1 Mar 2007 19:27:43 -0000
Received: (qmail 22382 invoked by uid 22791); 1 Mar 2007 19:27:42 -0000
X-Spam-Check-By: sourceware.org
Received: from mx2.palmsource.com (HELO mx2.palmsource.com) (12.7.175.14)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 Mar 2007 19:27:34 +0000
Received: from localhost (localhost [127.0.0.1]) 	by localhost.domain.tld (Postfix) with ESMTP 	id 331CB12872B; Thu,  1 Mar 2007 11:27:33 -0800 (PST)
Received: from mx2.palmsource.com ([127.0.0.1])  by localhost (mx2.palmsource.com [127.0.0.1]) (amavisd-new, port 10024)  with LMTP id 27590-01-15; Thu,  1 Mar 2007 11:27:32 -0800 (PST)
Received: from ussunex01.palmsource.com (unknown [192.168.101.9]) 	by mx2.palmsource.com (Postfix) with ESMTP 	id 22B6C1286B7; Thu,  1 Mar 2007 11:27:32 -0800 (PST)
Received: from 192.168.92.81 ([192.168.92.81]) by ussunex01.palmsource.com ([192.168.101.9]) via Exchange Front-End Server owa.palmsource.com ([10.0.20.17]) with Microsoft Exchange Server HTTP-DAV ;  Thu,  1 Mar 2007 19:27:32 +0000
Received: from svmsnyderlnx by owa.palmsource.com; 01 Mar 2007 11:27:31 -0800
Subject: Re: gdb testsuite Makefile.in issue
From: Michael Snyder <Michael.Snyder@palmsource.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb@sourceware.org
In-Reply-To: <20070301000027.GA27101@caradoc.them.org>
References: <1172705549.9783.5.camel@localhost.localdomain> 	 <20070301000027.GA27101@caradoc.them.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: Thu, 01 Mar 2007 19:27:00 -0000
Message-Id: <1172777251.9783.15.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.4.1
X-IsSubscribed: yes
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2007-03/txt/msg00026.txt.bz2

On Wed, 2007-02-28 at 19:00 -0500, Daniel Jacobowitz wrote:
> On Wed, Feb 28, 2007 at 03:32:29PM -0800, Michael Snyder wrote:
> > Folks, 
> > 
> > The following line has frequently caused me problems:
> > 
> >       t='$(program_transform_name)'; echo runtest | sed -e '' $$t; \
> > 
> > I think you do not run into it if you have dejagnu in your
> > source tree, or if your host == target.  But if those conditions
> > are not met, this line bombs.
> > 
> > My shell script foo is not strong, but I believe it should be
> > "sed -e '$$t';", not "sed -e '' $$t'"
> > 
> > Yes?  No?
> 
> Why should it be any of those?  It's just runtest, not
> $target-runtest.  The line gets overridden anyway if you run make
> check up a directory, I imagine that's why I never see it.
> 
> Anyway, gcc uses:
> 
> AR_FOR_TARGET := $(shell \
>   if [ -f $(objdir)/../binutils/ar ] ; then \
>     echo $(objdir)/../binutils/ar ; \
>   else \
>     if [ "$(host)" = "$(target)" ] ; then \
>       echo $(AR); \
>     else \
>        t='$(program_transform_name)'; echo ar | sed -e $$t ; \
>     fi; \
>   fi)
> 
> So I would imagine that removing the '' is all it takes.  Or maybe
> those are wrong too, I don't think they get used much.

In point of fact, what I've been doing for years now 
is to just remove them.

Do we agree that they're wrong as they are?
Let's get rid of them...