From: Daniel Jacobowitz <drow@false.org>
To: Michael Snyder <Michael.Snyder@palmsource.com>
Cc: gdb@sourceware.org
Subject: Re: gdb testsuite Makefile.in issue
Date: Thu, 01 Mar 2007 00:00:00 -0000 [thread overview]
Message-ID: <20070301000027.GA27101@caradoc.them.org> (raw)
In-Reply-To: <1172705549.9783.5.camel@localhost.localdomain>
On Wed, Feb 28, 2007 at 03:32:29PM -0800, Michael Snyder wrote:
> Folks,
>
> The following line has frequently caused me problems:
>
> t='$(program_transform_name)'; echo runtest | sed -e '' $$t; \
>
> I think you do not run into it if you have dejagnu in your
> source tree, or if your host == target. But if those conditions
> are not met, this line bombs.
>
> My shell script foo is not strong, but I believe it should be
> "sed -e '$$t';", not "sed -e '' $$t'"
>
> Yes? No?
Why should it be any of those? It's just runtest, not
$target-runtest. The line gets overridden anyway if you run make
check up a directory, I imagine that's why I never see it.
Anyway, gcc uses:
AR_FOR_TARGET := $(shell \
if [ -f $(objdir)/../binutils/ar ] ; then \
echo $(objdir)/../binutils/ar ; \
else \
if [ "$(host)" = "$(target)" ] ; then \
echo $(AR); \
else \
t='$(program_transform_name)'; echo ar | sed -e $$t ; \
fi; \
fi)
So I would imagine that removing the '' is all it takes. Or maybe
those are wrong too, I don't think they get used much.
--
Daniel Jacobowitz
CodeSourcery
next parent reply other threads:[~2007-03-01 0:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1172705549.9783.5.camel@localhost.localdomain>
2007-03-01 0:00 ` Daniel Jacobowitz [this message]
2007-03-01 19:27 ` Michael Snyder
2007-03-01 19:38 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070301000027.GA27101@caradoc.them.org \
--to=drow@false.org \
--cc=Michael.Snyder@palmsource.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox