From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13806 invoked by alias); 1 Mar 2007 00:00:37 -0000 Received: (qmail 13797 invoked by uid 22791); 1 Mar 2007 00:00:36 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 01 Mar 2007 00:00:31 +0000 Received: from dsl093-172-095.pit1.dsl.speakeasy.net ([66.93.172.95] helo=caradoc.them.org) by nevyn.them.org with esmtp (Exim 4.63) (envelope-from ) id 1HMYih-0002UL-Uc; Wed, 28 Feb 2007 19:00:27 -0500 Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HMYih-00078K-4G; Wed, 28 Feb 2007 19:00:27 -0500 Date: Thu, 01 Mar 2007 00:00:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb@sourceware.org Subject: Re: gdb testsuite Makefile.in issue Message-ID: <20070301000027.GA27101@caradoc.them.org> Mail-Followup-To: Michael Snyder , gdb@sourceware.org References: <1172705549.9783.5.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1172705549.9783.5.camel@localhost.localdomain> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00000.txt.bz2 On Wed, Feb 28, 2007 at 03:32:29PM -0800, Michael Snyder wrote: > Folks, > > The following line has frequently caused me problems: > > t='$(program_transform_name)'; echo runtest | sed -e '' $$t; \ > > I think you do not run into it if you have dejagnu in your > source tree, or if your host == target. But if those conditions > are not met, this line bombs. > > My shell script foo is not strong, but I believe it should be > "sed -e '$$t';", not "sed -e '' $$t'" > > Yes? No? Why should it be any of those? It's just runtest, not $target-runtest. The line gets overridden anyway if you run make check up a directory, I imagine that's why I never see it. Anyway, gcc uses: AR_FOR_TARGET := $(shell \ if [ -f $(objdir)/../binutils/ar ] ; then \ echo $(objdir)/../binutils/ar ; \ else \ if [ "$(host)" = "$(target)" ] ; then \ echo $(AR); \ else \ t='$(program_transform_name)'; echo ar | sed -e $$t ; \ fi; \ fi) So I would imagine that removing the '' is all it takes. Or maybe those are wrong too, I don't think they get used much. -- Daniel Jacobowitz CodeSourcery