Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: fche@redhat.com (Frank Ch. Eigler)
To: Ian Lance Taylor <ian@airs.com>
Cc: gdb-patches@sourceware.org
Subject: Re: PATCH RFA: Fix simulator handling of floating point absolute value
Date: Fri, 08 Jul 2005 15:38:00 -0000	[thread overview]
Message-ID: <y0mmzoxtijh.fsf@toenail.toronto.redhat.com> (raw)
In-Reply-To: <m3br5dx4ci.fsf@gossamer.airs.com>


ian wrote:

> [...]
> This patch changes sim_fpu_abs to always clear the sign bit of the
> argument.  It does not otherwise change the behaviour.  This, plus
> another patch I am about to sign, fixes the gcc copysign1 test for
> MIPS.
> 
> OK for mainline?
> [...]

Looks okay.  I can't find libgcc1 (soft-float emulation, the sim-fpu
code's ancestor) in current gcc any more to cross-check.  Newlib's
fabs implementation (libm/math/s_fabs.c) appears to clear the sign bit
in the same way as your new code.


- FChE


      parent reply	other threads:[~2005-07-08 15:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-08  5:19 Ian Lance Taylor
2005-07-08 14:03 ` Daniel Jacobowitz
2005-07-08 17:51   ` Ian Lance Taylor
2005-07-08 18:44     ` Daniel Jacobowitz
2005-07-08 15:38 ` Frank Ch. Eigler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y0mmzoxtijh.fsf@toenail.toronto.redhat.com \
    --to=fche@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ian@airs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox