From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-40245-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 8814 invoked by alias); 8 Jul 2005 15:38:35 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 7952 invoked by uid 22791); 8 Jul 2005 15:38:14 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 08 Jul 2005 15:38:14 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j68FcBqc025787;
	Fri, 8 Jul 2005 11:38:11 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j68FcBV30296;
	Fri, 8 Jul 2005 11:38:11 -0400
Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id j68FcB1M014777;
	Fri, 8 Jul 2005 11:38:11 -0400
Received: from toenail.toronto.redhat.com (toenail.toronto.redhat.com [172.16.14.211])
	by touchme.toronto.redhat.com (Postfix) with ESMTP
	id 0716B800008; Fri,  8 Jul 2005 11:38:11 -0400 (EDT)
Received: from toenail.toronto.redhat.com (localhost.localdomain [127.0.0.1])
	by toenail.toronto.redhat.com (8.13.1/8.12.5) with ESMTP id j68FcAwo032586;
	Fri, 8 Jul 2005 11:38:10 -0400
Received: (from fche@localhost)
	by toenail.toronto.redhat.com (8.13.1/8.13.1/Submit) id j68FcAt5032583;
	Fri, 8 Jul 2005 11:38:10 -0400
To: Ian Lance Taylor <ian@airs.com>
Cc: gdb-patches@sourceware.org
Subject: Re: PATCH RFA: Fix simulator handling of floating point absolute value
References: <m3br5dx4ci.fsf@gossamer.airs.com>
X-Hashcash: 1:20:050708:ian@airs.com::qoeVPfXgzwf1uyWz:000003oxx
X-Hashcash: 1:20:050708:gdb-patches@sourceware.org::paGSJUajnB9/gMYY:000000000000000000000000000000000005a2L
From: fche@redhat.com (Frank Ch. Eigler)
Date: Fri, 08 Jul 2005 15:38:00 -0000
In-Reply-To: <m3br5dx4ci.fsf@gossamer.airs.com>
Message-ID: <y0mmzoxtijh.fsf@toenail.toronto.redhat.com>
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2005-07/txt/msg00083.txt.bz2


ian wrote:

> [...]
> This patch changes sim_fpu_abs to always clear the sign bit of the
> argument.  It does not otherwise change the behaviour.  This, plus
> another patch I am about to sign, fixes the gcc copysign1 test for
> MIPS.
> 
> OK for mainline?
> [...]

Looks okay.  I can't find libgcc1 (soft-float emulation, the sim-fpu
code's ancestor) in current gcc any more to cross-check.  Newlib's
fabs implementation (libm/math/s_fabs.c) appears to clear the sign bit
in the same way as your new code.


- FChE