Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ian Lance Taylor <ian@airs.com>
To: gdb-patches@sourceware.org
Subject: PATCH RFA: Fix simulator handling of floating point absolute value
Date: Fri, 08 Jul 2005 05:19:00 -0000	[thread overview]
Message-ID: <m3br5dx4ci.fsf@gossamer.airs.com> (raw)

The common simulator routine sim_fpu_abs is used by MIPS, MN10300,
SH64, and perhaps some CGEN generated simulators (it is called by
cgen-accfp.c).  On most, and perhaps all, hardware, a floating point
absolute value instruction simply clears the sign bit.  However,
sim_fpu_abs does not clear the sign bit when given a NaN.  For MIPS,
this causes the gcc test gcc.c-torture/execute/ieee/copysign1.c to
fail.

This patch changes sim_fpu_abs to always clear the sign bit of the
argument.  It does not otherwise change the behaviour.  This, plus
another patch I am about to sign, fixes the gcc copysign1 test for
MIPS.

OK for mainline?

Ian


2005-07-07  Ian Lance Taylor  <ian@airs.com>

	* sim-fpu.c (sim_fpu_abs): Always clear the sign bit.


Index: common/sim-fpu.c
===================================================================
RCS file: /cvs/src/src/sim/common/sim-fpu.c,v
retrieving revision 1.8
diff -p -u -r1.8 sim-fpu.c
--- common/sim-fpu.c	22 Jun 2003 13:36:26 -0000	1.8
+++ common/sim-fpu.c	8 Jul 2005 05:05:12 -0000
@@ -1733,19 +1744,13 @@ INLINE_SIM_FPU (int)
 sim_fpu_abs (sim_fpu *f,
 	     const sim_fpu *r)
 {
+  *f = *r;
+  f->sign = 0;
   if (sim_fpu_is_snan (r))
     {
-      *f = *r;
       f->class = sim_fpu_class_qnan;
       return sim_fpu_status_invalid_snan;
     }
-  if (sim_fpu_is_qnan (r))
-    {
-      *f = *r;
-      return 0;
-    }
-  *f = *r;
-  f->sign = 0;
   return 0;
 }
 


             reply	other threads:[~2005-07-08  5:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-08  5:19 Ian Lance Taylor [this message]
2005-07-08 14:03 ` Daniel Jacobowitz
2005-07-08 17:51   ` Ian Lance Taylor
2005-07-08 18:44     ` Daniel Jacobowitz
2005-07-08 15:38 ` Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3br5dx4ci.fsf@gossamer.airs.com \
    --to=ian@airs.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox