From: Daniel Jacobowitz <drow@false.org>
To: Ian Lance Taylor <ian@airs.com>
Cc: gdb-patches@sourceware.org
Subject: Re: PATCH RFA: Fix simulator handling of floating point absolute value
Date: Fri, 08 Jul 2005 14:03:00 -0000 [thread overview]
Message-ID: <20050708140058.GA17316@nevyn.them.org> (raw)
In-Reply-To: <m3br5dx4ci.fsf@gossamer.airs.com>
On Thu, Jul 07, 2005 at 10:18:53PM -0700, Ian Lance Taylor wrote:
> The common simulator routine sim_fpu_abs is used by MIPS, MN10300,
> SH64, and perhaps some CGEN generated simulators (it is called by
> cgen-accfp.c). On most, and perhaps all, hardware, a floating point
> absolute value instruction simply clears the sign bit. However,
> sim_fpu_abs does not clear the sign bit when given a NaN. For MIPS,
> this causes the gcc test gcc.c-torture/execute/ieee/copysign1.c to
> fail.
>
> This patch changes sim_fpu_abs to always clear the sign bit of the
> argument. It does not otherwise change the behaviour. This, plus
> another patch I am about to sign, fixes the gcc copysign1 test for
> MIPS.
>
> OK for mainline?
I have no references for this concern, but could you check that this
change is appropriate for at least MN10300 and SH64, since they share
ths code?
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-07-08 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 5:19 Ian Lance Taylor
2005-07-08 14:03 ` Daniel Jacobowitz [this message]
2005-07-08 17:51 ` Ian Lance Taylor
2005-07-08 18:44 ` Daniel Jacobowitz
2005-07-08 15:38 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050708140058.GA17316@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=ian@airs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox