From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9597 invoked by alias); 8 Jul 2005 14:03:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8313 invoked by uid 22791); 8 Jul 2005 14:01:02 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 08 Jul 2005 14:01:02 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1DqtPX-0004WR-1A; Fri, 08 Jul 2005 10:00:59 -0400 Date: Fri, 08 Jul 2005 14:03:00 -0000 From: Daniel Jacobowitz To: Ian Lance Taylor Cc: gdb-patches@sourceware.org Subject: Re: PATCH RFA: Fix simulator handling of floating point absolute value Message-ID: <20050708140058.GA17316@nevyn.them.org> Mail-Followup-To: Ian Lance Taylor , gdb-patches@sourceware.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00082.txt.bz2 On Thu, Jul 07, 2005 at 10:18:53PM -0700, Ian Lance Taylor wrote: > The common simulator routine sim_fpu_abs is used by MIPS, MN10300, > SH64, and perhaps some CGEN generated simulators (it is called by > cgen-accfp.c). On most, and perhaps all, hardware, a floating point > absolute value instruction simply clears the sign bit. However, > sim_fpu_abs does not clear the sign bit when given a NaN. For MIPS, > this causes the gcc test gcc.c-torture/execute/ieee/copysign1.c to > fail. > > This patch changes sim_fpu_abs to always clear the sign bit of the > argument. It does not otherwise change the behaviour. This, plus > another patch I am about to sign, fixes the gcc copysign1 test for > MIPS. > > OK for mainline? I have no references for this concern, but could you check that this change is appropriate for at least MN10300 and SH64, since they share ths code? -- Daniel Jacobowitz CodeSourcery, LLC