RFA: gdb.base/charset.exp: don't use expect_out without regexp groups

RFA: gdb.base/charset.exp: don't use expect_out without regexp groups

[Jim Blandy]

This looks like a cut-and-paste mistake to me.  There's nothing in the
regexp for $expect_out to be referring to, so (in my case) this would
grab random text produced by callfuncs.exp and treat it as a host
charset name.

2004-06-03  Jim Blandy  <jimb@redhat.com>

	* gdb.base/charset.exp: Don't refer to $expect_out(1,string) in
	cases where the regexp has no groups; this grabs random text from
	the previous test suite, whatever that was.  Remove commented-out
	code.

Index: gdb/testsuite/gdb.base/charset.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/charset.exp,v
retrieving revision 1.3
diff -c -p -r1.3 charset.exp
*** gdb/testsuite/gdb.base/charset.exp	26 Feb 2004 17:23:23 -0000	1.3
--- gdb/testsuite/gdb.base/charset.exp	4 Jun 2004 04:30:40 -0000
*************** gdb_expect {
*** 200,206 ****
  
      -re "\\.\r\n$gdb_prompt $" {
  	#set host_charset_list $expect_out(1,string)
- 	set charsets($expect_out(1,string)) 1
  	pass "capture valid host charsets"
      }
  
--- 200,205 ----

Re: RFA: gdb.base/charset.exp: don't use expect_out without regexp groups

[Michael Elizabeth Chastain]

Proofread, looks okay to me.

Testing?  Did you test it?

In the ChangeLog, you say "remove commented-out code", but in the
patch, there's no removal of commented-out code.

Michael C

Re: RFA: gdb.base/charset.exp: don't use expect_out without regexp groups

[Jim Blandy]

mec.gnu@mindspring.com (Michael Elizabeth Chastain) writes:

> Proofread, looks okay to me.
> 
> Testing?  Did you test it?

Tested on powerpc-ibm-aix4.3.3.0, powerpc-unknown-linux-gnu, and
i686-pc-linux-gnu. 

> In the ChangeLog, you say "remove commented-out code", but in the
> patch, there's no removal of commented-out code.

Thanks --- I decided to submit that as a separate patch, but forgot to
update the ChangeLog entry.  Corrected:

2004-06-03  Jim Blandy  <jimb@redhat.com>

	* gdb.base/charset.exp: Don't refer to $expect_out(1,string) in
	cases where the regexp has no groups; this grabs random text from
	the previous test suite, whatever that was.

Index: gdb/testsuite/gdb.base/charset.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/charset.exp,v
retrieving revision 1.3
diff -c -p -r1.3 charset.exp
*** gdb/testsuite/gdb.base/charset.exp	26 Feb 2004 17:23:23 -0000	1.3
--- gdb/testsuite/gdb.base/charset.exp	4 Jun 2004 04:30:40 -0000
*************** gdb_expect {
*** 200,206 ****
  
      -re "\\.\r\n$gdb_prompt $" {
  	#set host_charset_list $expect_out(1,string)
- 	set charsets($expect_out(1,string)) 1
  	pass "capture valid host charsets"
      }
  
--- 200,205 ----

Re: RFA: gdb.base/charset.exp: don't use expect_out without regexp groups

[Michael Elizabeth Chastain]

> Tested on powerpc-ibm-aix4.3.3.0, powerpc-unknown-linux-gnu, and
> i686-pc-linux-gnu. 

Cool.

Recommended for self-approval.

Here's the add-on hit (which is a separate issue) ... can I get you
to mail in one of these powerpc-ibm-aix4.3.3.0 gdb.sum files to
gdb-testers.  Like, "grep -v '^PASS' gdb.sum" to remove the PASS
results first.  And add a blurb at the top saying what compiler was
used to compile the test programs.

Michael C

===

2004-06-03  Jim Blandy  <jimb@redhat.com>

	* gdb.base/charset.exp: Don't refer to $expect_out(1,string) in
	cases where the regexp has no groups; this grabs random text from
	the previous test suite, whatever that was.