From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26879 invoked by alias); 4 Jun 2004 04:31:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26871 invoked from network); 4 Jun 2004 04:31:59 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 4 Jun 2004 04:31:59 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i544Vwi5014577 for ; Fri, 4 Jun 2004 00:31:58 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i544Vv017055; Fri, 4 Jun 2004 00:31:57 -0400 To: gdb-patches@sources.redhat.com Subject: RFA: gdb.base/charset.exp: don't use expect_out without regexp groups From: Jim Blandy Date: Fri, 04 Jun 2004 04:31:00 -0000 Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-06/txt/msg00063.txt.bz2 This looks like a cut-and-paste mistake to me. There's nothing in the regexp for $expect_out to be referring to, so (in my case) this would grab random text produced by callfuncs.exp and treat it as a host charset name. 2004-06-03 Jim Blandy * gdb.base/charset.exp: Don't refer to $expect_out(1,string) in cases where the regexp has no groups; this grabs random text from the previous test suite, whatever that was. Remove commented-out code. Index: gdb/testsuite/gdb.base/charset.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/charset.exp,v retrieving revision 1.3 diff -c -p -r1.3 charset.exp *** gdb/testsuite/gdb.base/charset.exp 26 Feb 2004 17:23:23 -0000 1.3 --- gdb/testsuite/gdb.base/charset.exp 4 Jun 2004 04:30:40 -0000 *************** gdb_expect { *** 200,206 **** -re "\\.\r\n$gdb_prompt $" { #set host_charset_list $expect_out(1,string) - set charsets($expect_out(1,string)) 1 pass "capture valid host charsets" } --- 200,205 ----