From: Jim Blandy <jimb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: RFA: gdb.base/charset.exp: don't use expect_out without regexp groups
Date: Fri, 04 Jun 2004 04:31:00 -0000 [thread overview]
Message-ID: <vt2zn7kvtbh.fsf@zenia.home> (raw)
This looks like a cut-and-paste mistake to me. There's nothing in the
regexp for $expect_out to be referring to, so (in my case) this would
grab random text produced by callfuncs.exp and treat it as a host
charset name.
2004-06-03 Jim Blandy <jimb@redhat.com>
* gdb.base/charset.exp: Don't refer to $expect_out(1,string) in
cases where the regexp has no groups; this grabs random text from
the previous test suite, whatever that was. Remove commented-out
code.
Index: gdb/testsuite/gdb.base/charset.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/charset.exp,v
retrieving revision 1.3
diff -c -p -r1.3 charset.exp
*** gdb/testsuite/gdb.base/charset.exp 26 Feb 2004 17:23:23 -0000 1.3
--- gdb/testsuite/gdb.base/charset.exp 4 Jun 2004 04:30:40 -0000
*************** gdb_expect {
*** 200,206 ****
-re "\\.\r\n$gdb_prompt $" {
#set host_charset_list $expect_out(1,string)
- set charsets($expect_out(1,string)) 1
pass "capture valid host charsets"
}
--- 200,205 ----
next reply other threads:[~2004-06-04 4:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-04 4:31 Jim Blandy [this message]
2004-06-04 16:18 Michael Elizabeth Chastain
2004-06-04 21:53 ` Jim Blandy
2004-06-04 23:46 Michael Elizabeth Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2zn7kvtbh.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox