From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26937 invoked by alias); 4 Jun 2004 21:53:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26930 invoked from network); 4 Jun 2004 21:53:47 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 4 Jun 2004 21:53:47 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i54Lrli5019371 for ; Fri, 4 Jun 2004 17:53:47 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i54Lrj011877; Fri, 4 Jun 2004 17:53:46 -0400 To: mec.gnu@mindspring.com (Michael Elizabeth Chastain) Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: gdb.base/charset.exp: don't use expect_out without regexp groups References: <20040604161852.ECE2B4B104@berman.michael-chastain.com> From: Jim Blandy Date: Fri, 04 Jun 2004 21:53:00 -0000 In-Reply-To: <20040604161852.ECE2B4B104@berman.michael-chastain.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-06/txt/msg00084.txt.bz2 mec.gnu@mindspring.com (Michael Elizabeth Chastain) writes: > Proofread, looks okay to me. > > Testing? Did you test it? Tested on powerpc-ibm-aix4.3.3.0, powerpc-unknown-linux-gnu, and i686-pc-linux-gnu. > In the ChangeLog, you say "remove commented-out code", but in the > patch, there's no removal of commented-out code. Thanks --- I decided to submit that as a separate patch, but forgot to update the ChangeLog entry. Corrected: 2004-06-03 Jim Blandy * gdb.base/charset.exp: Don't refer to $expect_out(1,string) in cases where the regexp has no groups; this grabs random text from the previous test suite, whatever that was. Index: gdb/testsuite/gdb.base/charset.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/charset.exp,v retrieving revision 1.3 diff -c -p -r1.3 charset.exp *** gdb/testsuite/gdb.base/charset.exp 26 Feb 2004 17:23:23 -0000 1.3 --- gdb/testsuite/gdb.base/charset.exp 4 Jun 2004 04:30:40 -0000 *************** gdb_expect { *** 200,206 **** -re "\\.\r\n$gdb_prompt $" { #set host_charset_list $expect_out(1,string) - set charsets($expect_out(1,string)) 1 pass "capture valid host charsets" } --- 200,205 ----