From: Eli Zaretskii <eliz@gnu.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: drow@false.org, denis.pilat@st.com, gdb-patches@sourceware.org
Subject: Re: [RFC] varobj deletion after the binary has changed
Date: Fri, 09 Feb 2007 15:43:00 -0000 [thread overview]
Message-ID: <uy7n79w0k.fsf@gnu.org> (raw)
In-Reply-To: <17867.31476.627368.180759@kahikatea.snap.net.nz> (message from Nick Roberts on Fri, 9 Feb 2007 08:33:08 +1300)
> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Fri, 9 Feb 2007 08:33:08 +1300
> Cc: Denis PILAT <denis.pilat@st.com>, gdb-patches <gdb-patches@sourceware.org>
>
> How about this?
Approved, provided that you fix the following:
> + @item
> + The range of values for fields with specified values e.g in_scope,
> + type_changed may be extended.
First, "e.g" lacks the second period and a comma after it ("e.g.,").
Second, in_scope and type_changed should be in @code or @samp.
Third, these two are not mentioned anywhere in the node you are
patching, so please either add a cross-reference to where they are
described or add some minimal description to the text.
> Reevaluate the expressions corresponding to the variable object
> @var{name} and all its direct and indirect children, and return the
> ! list of variable objects whose values have changed. @var{name} must
> ! be a root variable object.
The last sentence will begin with a non-capital letter, which is not
valid English. How about using `;' instead of a period before
@var{name}?
Thanks.
next prev parent reply other threads:[~2007-02-09 15:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 12:32 Denis PILAT
2007-01-23 12:45 ` Daniel Jacobowitz
2007-01-23 12:52 ` Vladimir Prus
2007-01-23 14:49 ` Denis PILAT
2007-01-24 21:49 ` Nick Roberts
2007-01-24 22:07 ` Daniel Jacobowitz
2007-01-24 22:08 ` Frédéric Riss
2007-01-24 22:18 ` Nick Roberts
2007-01-24 22:52 ` Frédéric Riss
2007-01-24 23:14 ` Nick Roberts
2007-01-25 2:41 ` Daniel Jacobowitz
2007-01-25 20:50 ` Nick Roberts
2007-01-26 7:25 ` Denis PILAT
2007-01-23 17:20 ` Denis PILAT
2007-01-25 17:28 ` Denis PILAT
2007-01-25 22:31 ` Nick Roberts
2007-01-25 23:27 ` Daniel Jacobowitz
2007-01-29 12:39 ` Denis PILAT
2007-01-29 22:12 ` Nick Roberts
2007-01-30 8:49 ` Denis PILAT
2007-01-31 19:07 ` Denis PILAT
2007-01-31 21:29 ` Nick Roberts
2007-02-01 9:49 ` Denis PILAT
2007-02-08 16:41 ` Daniel Jacobowitz
2007-02-08 19:33 ` Nick Roberts
2007-02-08 19:55 ` Daniel Jacobowitz
2007-02-09 15:43 ` Eli Zaretskii [this message]
2007-02-12 21:10 ` Denis PILAT
2007-02-13 0:11 ` Nick Roberts
2007-02-13 8:26 ` Denis PILAT
2007-02-20 16:06 ` Andreas Schwab
2007-02-20 16:17 ` Denis PILAT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uy7n79w0k.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=denis.pilat@st.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox