From: Denis PILAT <denis.pilat@st.com>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Eli Zaretskii <eliz@gnu.org>, drow@false.org, gdb-patches@sourceware.org
Subject: Re: [RFC] varobj deletion after the binary has changed
Date: Tue, 13 Feb 2007 08:26:00 -0000 [thread overview]
Message-ID: <45D17602.7010107@st.com> (raw)
In-Reply-To: <17873.537.58649.22396@kahikatea.snap.net.nz>
Nick Roberts wrote:
> > Thanks you for the documentation update.
> > Hereby is 2 patches I would like to commit, the C part and the new . exp
> > file.
> > I change the .exp file with your comment, with a newer copyright notice,
> > and with including value field in output of -var-create.
> > I also changed a comment plus typos in the C code.
> >
> > Daniel already approved the sources, Eli is near to be fine with the doc.
> > Could have a look once more into the following, at least for the
> > ChangeLog entry ?
> > Then how could we synchronize our commit ?
>
> I've committed my documentation with requested changes (see below). All you
> need to do is commit yours.
>
> > 2007-02-12 Denis Pilat <denis.pilat@st.com>
> >
> > * gdb.mi/mi-var-invalidate.exp: New files.
>
> New file.
>
> > 2007-02-12 Denis Pilat <denis.pilat@st.com>
> >
> > * varobj.c (struct varobj_root): Add is_valid member.
> > (varobj_get_type): Check for invalid varobj.
> > (varobj_get_attributes): Likewise.
> > (variable_editable):Likewise.
> > (varobj_update): Likewise plus use an enum for returned error values.
> > (new_root_variable): Set root varobj as valid by default.
> > (varobj_invalidate): New function.
> > * varobj.h (enum varobj_update_error): New enum.
> > (varobj_invalidate): New function.
> duplicate entry
>
> > * symfile.c (clear_symtab_users): Use varobj_invalidate.
> > * mi/mi-cmd-var.c (varobj_update_one): Change returned type to void and
> > use of new enum varobj_update_error to deal with errors.
>
> * varobj.h (enum varobj_update_error): New enum.
> * varobj.c (struct varobj_root): Add is_valid member.
> (varobj_get_type): Check for invalid varobj.
> (varobj_get_attributes): Likewise.
> (variable_editable):Likewise.
> (varobj_update): Likewise. Use varobj_update_error.
> (new_root_variable): Set root varobj as valid by default.
> (varobj_invalidate): New function.
> * symfile.c (clear_symtab_users): Use varobj_invalidate.
> * mi/mi-cmd-var.c (varobj_update_one): Change return type to void.
> Use varobj_update_error.
>
> (Suggestion)
>
>
The following has just been committed:
- symfile.c, varobj.c, varobj.h, mi/mi-cmd-var.c
- testsuite/gdb.mi/mi-var-invalidate.exp
--
Denis
next prev parent reply other threads:[~2007-02-13 8:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 12:32 Denis PILAT
2007-01-23 12:45 ` Daniel Jacobowitz
2007-01-23 12:52 ` Vladimir Prus
2007-01-23 14:49 ` Denis PILAT
2007-01-24 21:49 ` Nick Roberts
2007-01-24 22:07 ` Daniel Jacobowitz
2007-01-24 22:08 ` Frédéric Riss
2007-01-24 22:18 ` Nick Roberts
2007-01-24 22:52 ` Frédéric Riss
2007-01-24 23:14 ` Nick Roberts
2007-01-25 2:41 ` Daniel Jacobowitz
2007-01-25 20:50 ` Nick Roberts
2007-01-26 7:25 ` Denis PILAT
2007-01-23 17:20 ` Denis PILAT
2007-01-25 17:28 ` Denis PILAT
2007-01-25 22:31 ` Nick Roberts
2007-01-25 23:27 ` Daniel Jacobowitz
2007-01-29 12:39 ` Denis PILAT
2007-01-29 22:12 ` Nick Roberts
2007-01-30 8:49 ` Denis PILAT
2007-01-31 19:07 ` Denis PILAT
2007-01-31 21:29 ` Nick Roberts
2007-02-01 9:49 ` Denis PILAT
2007-02-08 16:41 ` Daniel Jacobowitz
2007-02-08 19:33 ` Nick Roberts
2007-02-08 19:55 ` Daniel Jacobowitz
2007-02-09 15:43 ` Eli Zaretskii
2007-02-12 21:10 ` Denis PILAT
2007-02-13 0:11 ` Nick Roberts
2007-02-13 8:26 ` Denis PILAT [this message]
2007-02-20 16:06 ` Andreas Schwab
2007-02-20 16:17 ` Denis PILAT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D17602.7010107@st.com \
--to=denis.pilat@st.com \
--cc=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox