From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Denis PILAT <denis.pilat@st.com>, Vladimir Prus <ghost@cs.msu.su>,
gdb-patches@sources.redhat.com
Subject: Re: [RFC] varobj deletion after the binary has changed
Date: Wed, 24 Jan 2007 22:07:00 -0000 [thread overview]
Message-ID: <20070124220715.GA31476@nevyn.them.org> (raw)
In-Reply-To: <17847.54349.654238.452957@kahikatea.snap.net.nz>
On Thu, Jan 25, 2007 at 10:49:01AM +1300, Nick Roberts wrote:
> The crash occurs because computing TYPE_CODE (type) involves a memory
> violation. This comes from "type = SYMBOL_TYPE (var)" in read_var_value, in
> turn from var = exp->elts[pc + 2].symbol which is from exp = var->root->exp of
> the variable object in question (if that makes sense!).
Right, that's about what I expected. A parsed exp has pointers into
the symbol table, which at this point has been flushed and reloaded.
For expressions not associated with a particular block, we ought to
reparse them from the original string if the symbol file changes. I'm
not sure what to do for things involving local variables; we need to
discard valid_block too, for the same reason. Breakpoints have similar
issues, which are handled in breakpoint.c, but they don't usually carry
block pointers around.
The other things which could be invalidated when we reload the file
are the type pointers in values. So, we probably need to discard all
values when reloading the file.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-01-24 22:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 12:32 Denis PILAT
2007-01-23 12:45 ` Daniel Jacobowitz
2007-01-23 12:52 ` Vladimir Prus
2007-01-23 14:49 ` Denis PILAT
2007-01-24 21:49 ` Nick Roberts
2007-01-24 22:07 ` Daniel Jacobowitz [this message]
2007-01-24 22:08 ` Frédéric Riss
2007-01-24 22:18 ` Nick Roberts
2007-01-24 22:52 ` Frédéric Riss
2007-01-24 23:14 ` Nick Roberts
2007-01-25 2:41 ` Daniel Jacobowitz
2007-01-25 20:50 ` Nick Roberts
2007-01-26 7:25 ` Denis PILAT
2007-01-23 17:20 ` Denis PILAT
2007-01-25 17:28 ` Denis PILAT
2007-01-25 22:31 ` Nick Roberts
2007-01-25 23:27 ` Daniel Jacobowitz
2007-01-29 12:39 ` Denis PILAT
2007-01-29 22:12 ` Nick Roberts
2007-01-30 8:49 ` Denis PILAT
2007-01-31 19:07 ` Denis PILAT
2007-01-31 21:29 ` Nick Roberts
2007-02-01 9:49 ` Denis PILAT
2007-02-08 16:41 ` Daniel Jacobowitz
2007-02-08 19:33 ` Nick Roberts
2007-02-08 19:55 ` Daniel Jacobowitz
2007-02-09 15:43 ` Eli Zaretskii
2007-02-12 21:10 ` Denis PILAT
2007-02-13 0:11 ` Nick Roberts
2007-02-13 8:26 ` Denis PILAT
2007-02-20 16:06 ` Andreas Schwab
2007-02-20 16:17 ` Denis PILAT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070124220715.GA31476@nevyn.them.org \
--to=drow@false.org \
--cc=denis.pilat@st.com \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox