From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26343 invoked by alias); 13 Feb 2007 08:26:12 -0000 Received: (qmail 26322 invoked by uid 22791); 13 Feb 2007 08:26:11 -0000 X-Spam-Check-By: sourceware.org Received: from vir-del-03.spheriq.net (HELO vir-del-03.spheriq.net) (194.50.41.42) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Feb 2007 08:26:01 +0000 Received: from vir-out-01.spheriq.net ([194.50.41.30]) by vir-del-03.spheriq.net with ESMTP id l1D8Pvwe024207 for ; Tue, 13 Feb 2007 08:25:57 GMT Received: from vir-cus-02.spheriq.net (vir-cus-02.spheriq.net [194.50.41.86]) by vir-out-01.spheriq.net with ESMTP id l1D8Pt4t017369 for ; Tue, 13 Feb 2007 08:25:57 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by vir-cus-02.spheriq.net with ESMTP id l1D8Prkk020154 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 13 Feb 2007 08:25:55 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 49307DA48; Tue, 13 Feb 2007 08:25:45 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2581C47294; Tue, 13 Feb 2007 08:25:40 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CJS48746 (AUTH "denis pilat"); Tue, 13 Feb 2007 09:25:39 +0100 (CET) Message-ID: <45D17602.7010107@st.com> Date: Tue, 13 Feb 2007 08:26:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.9 (X11/20061206) MIME-Version: 1.0 To: Nick Roberts Cc: Eli Zaretskii , drow@false.org, gdb-patches@sourceware.org Subject: Re: [RFC] varobj deletion after the binary has changed References: <20070123124457.GA1600@nevyn.them.org> <45B63A49.4010609@st.com> <45B8E8A8.9040904@st.com> <17849.12231.246980.478169@kahikatea.snap.net.nz> <20070125232731.GA30178@nevyn.them.org> <45BDEAEC.1050006@st.com> <17854.28971.170898.231523@kahikatea.snap.net.nz> <45C0B042.9040308@st.com> <17857.2617.164646.935952@kahikatea.snap.net.nz> <45C1B78C.60605@st.com> <20070208164103.GA13544@nevyn.them.org> <17867.31476.627368.180759@kahikatea.snap.net.nz> <45D05B3B.5050408@st.com> <17873.537.58649.22396@kahikatea.snap.net.nz> In-Reply-To: <17873.537.58649.22396@kahikatea.snap.net.nz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00176.txt.bz2 Nick Roberts wrote: > > Thanks you for the documentation update. > > Hereby is 2 patches I would like to commit, the C part and the new . exp > > file. > > I change the .exp file with your comment, with a newer copyright notice, > > and with including value field in output of -var-create. > > I also changed a comment plus typos in the C code. > > > > Daniel already approved the sources, Eli is near to be fine with the doc. > > Could have a look once more into the following, at least for the > > ChangeLog entry ? > > Then how could we synchronize our commit ? > > I've committed my documentation with requested changes (see below). All you > need to do is commit yours. > > > 2007-02-12 Denis Pilat > > > > * gdb.mi/mi-var-invalidate.exp: New files. > > New file. > > > 2007-02-12 Denis Pilat > > > > * varobj.c (struct varobj_root): Add is_valid member. > > (varobj_get_type): Check for invalid varobj. > > (varobj_get_attributes): Likewise. > > (variable_editable):Likewise. > > (varobj_update): Likewise plus use an enum for returned error values. > > (new_root_variable): Set root varobj as valid by default. > > (varobj_invalidate): New function. > > * varobj.h (enum varobj_update_error): New enum. > > (varobj_invalidate): New function. > duplicate entry > > > * symfile.c (clear_symtab_users): Use varobj_invalidate. > > * mi/mi-cmd-var.c (varobj_update_one): Change returned type to void and > > use of new enum varobj_update_error to deal with errors. > > * varobj.h (enum varobj_update_error): New enum. > * varobj.c (struct varobj_root): Add is_valid member. > (varobj_get_type): Check for invalid varobj. > (varobj_get_attributes): Likewise. > (variable_editable):Likewise. > (varobj_update): Likewise. Use varobj_update_error. > (new_root_variable): Set root varobj as valid by default. > (varobj_invalidate): New function. > * symfile.c (clear_symtab_users): Use varobj_invalidate. > * mi/mi-cmd-var.c (varobj_update_one): Change return type to void. > Use varobj_update_error. > > (Suggestion) > > The following has just been committed: - symfile.c, varobj.c, varobj.h, mi/mi-cmd-var.c - testsuite/gdb.mi/mi-var-invalidate.exp -- Denis