From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19316 invoked by alias); 9 Feb 2007 15:43:57 -0000 Received: (qmail 19306 invoked by uid 22791); 9 Feb 2007 15:43:56 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Feb 2007 15:43:45 +0000 Received: from HOME-C4E4A596F7 (IGLD-83-130-217-134.inter.net.il [83.130.217.134]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id HCA81341 (AUTH halo1); Fri, 9 Feb 2007 17:43:39 +0200 (IST) Date: Fri, 09 Feb 2007 15:43:00 -0000 Message-Id: From: Eli Zaretskii To: Nick Roberts CC: drow@false.org, denis.pilat@st.com, gdb-patches@sourceware.org In-reply-to: <17867.31476.627368.180759@kahikatea.snap.net.nz> (message from Nick Roberts on Fri, 9 Feb 2007 08:33:08 +1300) Subject: Re: [RFC] varobj deletion after the binary has changed Reply-to: Eli Zaretskii References: <20070123124457.GA1600@nevyn.them.org> <45B63A49.4010609@st.com> <45B8E8A8.9040904@st.com> <17849.12231.246980.478169@kahikatea.snap.net.nz> <20070125232731.GA30178@nevyn.them.org> <45BDEAEC.1050006@st.com> <17854.28971.170898.231523@kahikatea.snap.net.nz> <45C0B042.9040308@st.com> <17857.2617.164646.935952@kahikatea.snap.net.nz> <45C1B78C.60605@st.com> <20070208164103.GA13544@nevyn.them.org> <17867.31476.627368.180759@kahikatea.snap.net.nz> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00126.txt.bz2 > From: Nick Roberts > Date: Fri, 9 Feb 2007 08:33:08 +1300 > Cc: Denis PILAT , gdb-patches > > How about this? Approved, provided that you fix the following: > + @item > + The range of values for fields with specified values e.g in_scope, > + type_changed may be extended. First, "e.g" lacks the second period and a comma after it ("e.g.,"). Second, in_scope and type_changed should be in @code or @samp. Third, these two are not mentioned anywhere in the node you are patching, so please either add a cross-reference to where they are described or add some minimal description to the text. > Reevaluate the expressions corresponding to the variable object > @var{name} and all its direct and indirect children, and return the > ! list of variable objects whose values have changed. @var{name} must > ! be a root variable object. The last sentence will begin with a non-capital letter, which is not valid English. How about using `;' instead of a period before @var{name}? Thanks.