From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org
Subject: Re: [ob] More warnings; Call for assistance
Date: Wed, 18 Jan 2006 04:16:00 -0000 [thread overview]
Message-ID: <uvewi6uhj.fsf@gnu.org> (raw)
In-Reply-To: <20060117211455.GA12897@nevyn.them.org> (message from Daniel Jacobowitz on Tue, 17 Jan 2006 16:14:55 -0500)
> Date: Tue, 17 Jan 2006 16:14:55 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sourceware.org
>
> I've fixed several places where we passed ints as var_uinteger or
> unsigned ints as var_zinteger to the CLI. They're a bit subtle to fix
> (witness my earlier message today about set complaints -1). They've
> never bitten us, but they could.
These cases indeed need fixing, since they reveal unclean code. If
there are more of them, I think we should fix them too. But the bulk
of these warnings are not for this kind of problems. I especially
dislike these warnings when the pointer is passed to a library
function.
> Shall we discard the remaining (more minor) cases and turn off this
> warning?
I think so, yes. We have better uses for our energy right now.
next prev parent reply other threads:[~2006-01-18 4:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 15:17 Daniel Jacobowitz
2006-01-17 15:22 ` Daniel Jacobowitz
2006-01-17 19:37 ` Jim Blandy
2006-01-17 19:46 ` Daniel Jacobowitz
2006-01-17 20:11 ` Eli Zaretskii
2006-01-20 23:06 ` Daniel Jacobowitz
2006-01-21 10:07 ` Eli Zaretskii
2006-01-21 15:18 ` Daniel Jacobowitz
2006-01-17 20:57 ` Jim Blandy
2006-01-17 20:17 ` Eli Zaretskii
2006-01-20 23:09 ` Daniel Jacobowitz
2006-01-17 20:19 ` Eli Zaretskii
2006-01-17 20:23 ` Daniel Jacobowitz
2006-01-17 21:08 ` Eli Zaretskii
2006-01-17 21:14 ` Daniel Jacobowitz
2006-01-18 4:16 ` Eli Zaretskii [this message]
2006-01-18 1:15 ` Jim Blandy
2006-01-18 23:33 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uvewi6uhj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox