Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [ob] More warnings; Call for assistance
Date: Tue, 17 Jan 2006 21:14:00 -0000	[thread overview]
Message-ID: <20060117211455.GA12897@nevyn.them.org> (raw)
In-Reply-To: <uy81e7ehq.fsf@gnu.org>

On Tue, Jan 17, 2006 at 11:04:33PM +0200, Eli Zaretskii wrote:
> I have this:
> 
>    http://lists.gnu.org/archive/html/emacs-devel/2005-12/msg01743.html
> 
> I don't know if this counts as a reference, but it's good enough for
> me ;-)

I've seen no sign of this change in GCC.  I will follow up with them.

> > Also, do you think the warning is useless?
> 
> I think it's too pedantic; I think it's a false alarm 99.99% of the
> time.  But if you think I'm wrong, please describe situations where
> this warning would point to a real trouble.

I've fixed several places where we passed ints as var_uinteger or
unsigned ints as var_zinteger to the CLI.  They're a bit subtle to fix
(witness my earlier message today about set complaints -1).  They've
never bitten us, but they could.

> > If you think it's useless, I'll just stop, and we'll go with Mark's
> > patch to disable it.
> 
> Hmm.. were you fixing only this precise warning?  I thought I've seen
> other, more serious warnings as well fixed by your recent changes.

I fixed I believe two warnings other than this, caused by unrelated
changes in GCC.  The bulk are for this issue.

Shall we discard the remaining (more minor) cases and turn off this
warning?

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-01-17 21:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-17 15:17 Daniel Jacobowitz
2006-01-17 15:22 ` Daniel Jacobowitz
2006-01-17 19:37   ` Jim Blandy
2006-01-17 19:46     ` Daniel Jacobowitz
2006-01-17 20:11       ` Eli Zaretskii
2006-01-20 23:06         ` Daniel Jacobowitz
2006-01-21 10:07           ` Eli Zaretskii
2006-01-21 15:18             ` Daniel Jacobowitz
2006-01-17 20:57       ` Jim Blandy
2006-01-17 20:17     ` Eli Zaretskii
2006-01-20 23:09   ` Daniel Jacobowitz
2006-01-17 20:19 ` Eli Zaretskii
2006-01-17 20:23   ` Daniel Jacobowitz
2006-01-17 21:08     ` Eli Zaretskii
2006-01-17 21:14       ` Daniel Jacobowitz [this message]
2006-01-18  4:16         ` Eli Zaretskii
2006-01-18  1:15 ` Jim Blandy
2006-01-18 23:33   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060117211455.GA12897@nevyn.them.org \
    --to=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox