Re: [ob] More warnings; Call for assistance

[Daniel Jacobowitz <drow@false.org>]

On Tue, Jan 17, 2006 at 10:21:56AM -0500, Daniel Jacobowitz wrote:
> On Tue, Jan 17, 2006 at 10:17:31AM -0500, Daniel Jacobowitz wrote:
> > @@ -161,7 +161,7 @@ find_complaint (struct complaints *compl
> >     before we stop whining about it?  Default is no whining at all,
> >     since so many systems have ill-constructed symbol files.  */
> >  
> > -static unsigned int stop_whining = 0;
> > +static int stop_whining = 0;
> >  
> >  /* Print a complaint, and link the complaint block into a chain for
> >     later handling.  */
> 
> Oops!  I did check that this was correct within the logic of the file,
> but it still causes three test failures.  gdb.cp/maint.exp does
> "set complaints -1" and expects to get all complaints.
> 
> This is a var_zinteger, which is supposed to be signed - thus my
> change.  What maint.exp is doing is undocumented, and seems passingly
> illogical to me; does anyone object to my changing it to "set
> complaints 1000"?
> 
> The manual says:
> 
> `set complaints LIMIT'
>      Permits GDB to output LIMIT complaints about each type of unusual
>      symbols before becoming silent about the problem.  Set LIMIT to
>      zero to suppress all complaints; set it to a large number to
>      prevent complaints from being suppressed.

There were no objections, so I've checked this in.

-- 
Daniel Jacobowitz
CodeSourcery

2006-01-20  Daniel Jacobowitz  <dan@codesourcery.com>

	* gdb.cp/maint.exp: Set complaints to a positive value.

Index: testsuite/gdb.cp/maint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/maint.exp,v
retrieving revision 1.3
diff -u -p -r1.3 maint.exp
--- testsuite/gdb.cp/maint.exp	11 Feb 2004 14:01:25 -0000	1.3
+++ testsuite/gdb.cp/maint.exp	20 Jan 2006 23:07:52 -0000
@@ -1,4 +1,4 @@
-# Copyright 2003, 2004 Free Software Foundation Inc.
+# Copyright 2003, 2004, 2006 Free Software Foundation Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -59,7 +59,7 @@ proc test_first_component {} {
     # The function in question might complain; make sure that we see
     # all complaints.
 
-    gdb_test "set complaints -1" ""
+    gdb_test "set complaints 1000" ""
 
     test_single_component "foo"
     test_single_component "operator<<"