Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [ob] More warnings; Call for assistance
Date: Tue, 17 Jan 2006 15:22:00 -0000	[thread overview]
Message-ID: <20060117152156.GA3115@nevyn.them.org> (raw)
In-Reply-To: <20060117151730.GA2420@nevyn.them.org>

On Tue, Jan 17, 2006 at 10:17:31AM -0500, Daniel Jacobowitz wrote:
> @@ -161,7 +161,7 @@ find_complaint (struct complaints *compl
>     before we stop whining about it?  Default is no whining at all,
>     since so many systems have ill-constructed symbol files.  */
>  
> -static unsigned int stop_whining = 0;
> +static int stop_whining = 0;
>  
>  /* Print a complaint, and link the complaint block into a chain for
>     later handling.  */

Oops!  I did check that this was correct within the logic of the file,
but it still causes three test failures.  gdb.cp/maint.exp does
"set complaints -1" and expects to get all complaints.

This is a var_zinteger, which is supposed to be signed - thus my
change.  What maint.exp is doing is undocumented, and seems passingly
illogical to me; does anyone object to my changing it to "set
complaints 1000"?

The manual says:

`set complaints LIMIT'
     Permits GDB to output LIMIT complaints about each type of unusual
     symbols before becoming silent about the problem.  Set LIMIT to
     zero to suppress all complaints; set it to a large number to
     prevent complaints from being suppressed.


-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-01-17 15:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-17 15:17 Daniel Jacobowitz
2006-01-17 15:22 ` Daniel Jacobowitz [this message]
2006-01-17 19:37   ` Jim Blandy
2006-01-17 19:46     ` Daniel Jacobowitz
2006-01-17 20:11       ` Eli Zaretskii
2006-01-20 23:06         ` Daniel Jacobowitz
2006-01-21 10:07           ` Eli Zaretskii
2006-01-21 15:18             ` Daniel Jacobowitz
2006-01-17 20:57       ` Jim Blandy
2006-01-17 20:17     ` Eli Zaretskii
2006-01-20 23:09   ` Daniel Jacobowitz
2006-01-17 20:19 ` Eli Zaretskii
2006-01-17 20:23   ` Daniel Jacobowitz
2006-01-17 21:08     ` Eli Zaretskii
2006-01-17 21:14       ` Daniel Jacobowitz
2006-01-18  4:16         ` Eli Zaretskii
2006-01-18  1:15 ` Jim Blandy
2006-01-18 23:33   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060117152156.GA3115@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox