From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2621 invoked by alias); 17 Jan 2006 15:22:13 -0000 Received: (qmail 2609 invoked by uid 22791); 17 Jan 2006 15:22:11 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 17 Jan 2006 15:21:58 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Eysei-0000p0-5R for gdb-patches@sourceware.org; Tue, 17 Jan 2006 10:21:56 -0500 Date: Tue, 17 Jan 2006 15:22:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [ob] More warnings; Call for assistance Message-ID: <20060117152156.GA3115@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060117151730.GA2420@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060117151730.GA2420@nevyn.them.org> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00215.txt.bz2 On Tue, Jan 17, 2006 at 10:17:31AM -0500, Daniel Jacobowitz wrote: > @@ -161,7 +161,7 @@ find_complaint (struct complaints *compl > before we stop whining about it? Default is no whining at all, > since so many systems have ill-constructed symbol files. */ > > -static unsigned int stop_whining = 0; > +static int stop_whining = 0; > > /* Print a complaint, and link the complaint block into a chain for > later handling. */ Oops! I did check that this was correct within the logic of the file, but it still causes three test failures. gdb.cp/maint.exp does "set complaints -1" and expects to get all complaints. This is a var_zinteger, which is supposed to be signed - thus my change. What maint.exp is doing is undocumented, and seems passingly illogical to me; does anyone object to my changing it to "set complaints 1000"? The manual says: `set complaints LIMIT' Permits GDB to output LIMIT complaints about each type of unusual symbols before becoming silent about the problem. Set LIMIT to zero to suppress all complaints; set it to a large number to prevent complaints from being suppressed. -- Daniel Jacobowitz CodeSourcery