From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25899 invoked by alias); 17 Jan 2006 21:14:59 -0000 Received: (qmail 25891 invoked by uid 22791); 17 Jan 2006 21:14:59 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 17 Jan 2006 21:14:57 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EyyAJ-0003NB-Jb; Tue, 17 Jan 2006 16:14:55 -0500 Date: Tue, 17 Jan 2006 21:14:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [ob] More warnings; Call for assistance Message-ID: <20060117211455.GA12897@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , gdb-patches@sourceware.org References: <20060117151730.GA2420@nevyn.them.org> <20060117202323.GA11359@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00228.txt.bz2 On Tue, Jan 17, 2006 at 11:04:33PM +0200, Eli Zaretskii wrote: > I have this: > > http://lists.gnu.org/archive/html/emacs-devel/2005-12/msg01743.html > > I don't know if this counts as a reference, but it's good enough for > me ;-) I've seen no sign of this change in GCC. I will follow up with them. > > Also, do you think the warning is useless? > > I think it's too pedantic; I think it's a false alarm 99.99% of the > time. But if you think I'm wrong, please describe situations where > this warning would point to a real trouble. I've fixed several places where we passed ints as var_uinteger or unsigned ints as var_zinteger to the CLI. They're a bit subtle to fix (witness my earlier message today about set complaints -1). They've never bitten us, but they could. > > If you think it's useless, I'll just stop, and we'll go with Mark's > > patch to disable it. > > Hmm.. were you fixing only this precise warning? I thought I've seen > other, more serious warnings as well fixed by your recent changes. I fixed I believe two warnings other than this, caused by unrelated changes in GCC. The bulk are for this issue. Shall we discard the remaining (more minor) cases and turn off this warning? -- Daniel Jacobowitz CodeSourcery