From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26676 invoked by alias); 18 Jan 2006 04:16:45 -0000 Received: (qmail 26666 invoked by uid 22791); 18 Jan 2006 04:16:44 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 18 Jan 2006 04:16:41 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-69-206.inter.net.il [80.230.69.206]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id CMO93789 (AUTH halo1); Wed, 18 Jan 2006 06:16:38 +0200 (IST) Date: Wed, 18 Jan 2006 04:16:00 -0000 Message-Id: From: Eli Zaretskii To: gdb-patches@sourceware.org In-reply-to: <20060117211455.GA12897@nevyn.them.org> (message from Daniel Jacobowitz on Tue, 17 Jan 2006 16:14:55 -0500) Subject: Re: [ob] More warnings; Call for assistance Reply-to: Eli Zaretskii References: <20060117151730.GA2420@nevyn.them.org> <20060117202323.GA11359@nevyn.them.org> <20060117211455.GA12897@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00236.txt.bz2 > Date: Tue, 17 Jan 2006 16:14:55 -0500 > From: Daniel Jacobowitz > Cc: gdb-patches@sourceware.org > > I've fixed several places where we passed ints as var_uinteger or > unsigned ints as var_zinteger to the CLI. They're a bit subtle to fix > (witness my earlier message today about set complaints -1). They've > never bitten us, but they could. These cases indeed need fixing, since they reveal unclean code. If there are more of them, I think we should fix them too. But the bulk of these warnings are not for this kind of problems. I especially dislike these warnings when the pointer is passed to a library function. > Shall we discard the remaining (more minor) cases and turn off this > warning? I think so, yes. We have better uses for our energy right now.