Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sources.redhat.com
Subject: Re: mi tty commands
Date: Sat, 18 Jun 2005 08:27:00 -0000	[thread overview]
Message-ID: <ufyvg10cu.fsf@gnu.org> (raw)
In-Reply-To: <20050617211427.GA15201@nevyn.them.org> (message from Daniel Jacobowitz on Fri, 17 Jun 2005 17:14:28 -0400)

> Date: Fri, 17 Jun 2005 17:14:28 -0400
> From: Daniel Jacobowitz <drow@false.org>
> 
> On Fri, Jun 17, 2005 at 05:08:11PM -0400, Bob Rossi wrote:
> > > > -  c = add_com ("tty", class_run, tty_command,
> > > > -	       _("Set terminal for future runs of program being debugged."));
> > > > +  /* add the filename of the terminal connected to inferior I/O */
> > > > +  add_setshow_string_noescape_cmd ("inferior-tty", class_run,
> > > > +				   &inferior_io_terminal, _("\
> > > > +Set terminal for future runs of program being debugged."), _("\
> > > > +Show terminal for future runs of program being debugged."), _("\
> > > > +Usage: set inferior-tty /dev/pts/1"), NULL, NULL, &setlist, &showlist);
> > > >    set_cmd_completer (c, filename_completer);
> > > > +  add_com_alias ("tty", "set inferior-tty", class_alias, 0);
> > > 
> > > This seems nice.  I was thinking of replacing "tty" with "set tty"
> > > instead of "set inferior-tty", but I don't have a strong preference one
> > > way or the other.
> > 
> > I didn't change this, since there is an alias. However, the more I
> > think about it, it would be fine with me if this was changed to simply
> > 'tty'. Eventually, I might add a console-tty, which is the reason I was
> > more specific with inferior-tty, instead of just tty. What do you think?
> 
> Right - what we have now is "tty", this patch preserves "tty" and adds
> "set inferior-tty".  Might as well stay with that.  It's a little more
> descriptive.

My opinion as well.  In any case, the set/show commands should remain
consistent wrt the symmetry between the set and show command.  I
suggested to add an alias to "tty" for reasons of backward
compatibility.


  reply	other threads:[~2005-06-18  8:27 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-24 20:49 Bob Rossi
2005-02-26  4:33 ` Eli Zaretskii
2005-02-26  6:07   ` Bob Rossi
2005-02-26  8:25     ` Daniel Jacobowitz
2005-02-28 20:28       ` Bob Rossi
2005-03-02  2:52         ` Bob Rossi
2005-03-11  2:26           ` Bob Rossi
2005-05-23  3:13             ` Bob Rossi
2005-05-28 23:49               ` Daniel Jacobowitz
2005-05-29  8:37                 ` Eli Zaretskii
2005-05-29 16:22                   ` Daniel Jacobowitz
2005-05-29 18:10                     ` Eli Zaretskii
2005-05-29 19:05                       ` Daniel Jacobowitz
2005-05-30 15:48                   ` Bob Rossi
2005-06-01  0:14                     ` Bob Rossi
2005-06-01  4:00                       ` Eli Zaretskii
2005-06-01 13:07                         ` Bob Rossi
2005-06-01 17:42                           ` Bob Rossi
2005-06-01 20:25                             ` Eli Zaretskii
2005-06-02 22:17                               ` Bob Rossi
2005-06-03  6:48                                 ` Eli Zaretskii
2005-06-03 17:32                                   ` Bob Rossi
2005-06-10  2:28                                 ` Bob Rossi
2005-06-10  6:36                                   ` Eli Zaretskii
2005-06-10 11:04                                     ` Bob Rossi
2005-06-13  3:07                                 ` Daniel Jacobowitz
2005-06-13  6:09                                   ` Eli Zaretskii
2005-06-17 21:08                                   ` Bob Rossi
2005-06-17 21:14                                     ` Daniel Jacobowitz
2005-06-18  8:27                                       ` Eli Zaretskii [this message]
2005-06-18 12:29                                       ` Bob Rossi
2005-06-26 13:43                                         ` Bob Rossi
2005-07-03 18:43                                         ` Daniel Jacobowitz
2005-07-06 14:54                                           ` Bob Rossi
2005-07-10 21:08                                             ` Mark Kettenis
2005-07-10 21:32                                               ` Bob Rossi
2005-07-11 15:52                                               ` Bob Rossi
2005-07-11 18:41                                                 ` Mark Kettenis
2005-07-11 20:00                                                   ` Bob Rossi
2005-07-11 20:01                                                     ` Daniel Jacobowitz
2005-07-11 20:44                                                       ` Bob Rossi
2005-07-11 20:55                                                         ` Mark Kettenis
2005-07-11 21:26                                               ` Bob Rossi
2005-07-12 20:56                                                 ` Mark Kettenis
2005-07-14 14:51                                                   ` Bob Rossi
2005-06-01 20:12                           ` Eli Zaretskii
2005-06-01 20:43                             ` Bob Rossi
2005-06-02  3:48                               ` Eli Zaretskii
2005-05-30 15:48                 ` Bob Rossi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ufyvg10cu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox