From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13421 invoked by alias); 18 Jun 2005 08:27:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13408 invoked by uid 22791); 18 Jun 2005 08:27:22 -0000 Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sat, 18 Jun 2005 08:27:22 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-159-161.inter.net.il [80.230.159.161]) by romy.inter.net.il (MOS 3.5.8-GR) with ESMTP id BOL74580 (AUTH halo1); Sat, 18 Jun 2005 11:27:18 +0300 (IDT) Date: Sat, 18 Jun 2005 08:27:00 -0000 Message-Id: From: Eli Zaretskii To: gdb-patches@sources.redhat.com In-reply-to: <20050617211427.GA15201@nevyn.them.org> (message from Daniel Jacobowitz on Fri, 17 Jun 2005 17:14:28 -0400) Subject: Re: mi tty commands Reply-to: Eli Zaretskii References: <20050529205435.GA11243@white> <20050601001440.GB15414@white> <20050601130653.GA17103@white> <20050601174149.GA17309@white> <20050602221644.GA21263@white> <20050613030732.GE9288@nevyn.them.org> <20050617210811.GA27959@white> <20050617211427.GA15201@nevyn.them.org> X-SW-Source: 2005-06/txt/msg00277.txt.bz2 > Date: Fri, 17 Jun 2005 17:14:28 -0400 > From: Daniel Jacobowitz > > On Fri, Jun 17, 2005 at 05:08:11PM -0400, Bob Rossi wrote: > > > > - c = add_com ("tty", class_run, tty_command, > > > > - _("Set terminal for future runs of program being debugged.")); > > > > + /* add the filename of the terminal connected to inferior I/O */ > > > > + add_setshow_string_noescape_cmd ("inferior-tty", class_run, > > > > + &inferior_io_terminal, _("\ > > > > +Set terminal for future runs of program being debugged."), _("\ > > > > +Show terminal for future runs of program being debugged."), _("\ > > > > +Usage: set inferior-tty /dev/pts/1"), NULL, NULL, &setlist, &showlist); > > > > set_cmd_completer (c, filename_completer); > > > > + add_com_alias ("tty", "set inferior-tty", class_alias, 0); > > > > > > This seems nice. I was thinking of replacing "tty" with "set tty" > > > instead of "set inferior-tty", but I don't have a strong preference one > > > way or the other. > > > > I didn't change this, since there is an alias. However, the more I > > think about it, it would be fine with me if this was changed to simply > > 'tty'. Eventually, I might add a console-tty, which is the reason I was > > more specific with inferior-tty, instead of just tty. What do you think? > > Right - what we have now is "tty", this patch preserves "tty" and adds > "set inferior-tty". Might as well stay with that. It's a little more > descriptive. My opinion as well. In any case, the set/show commands should remain consistent wrt the symmetry between the set and show command. I suggested to add an alias to "tty" for reasons of backward compatibility.