Re: mi tty commands

[Bob Rossi <bob@brasko.net>]

On Sun, Jul 10, 2005 at 11:08:12PM +0200, Mark Kettenis wrote:
>    Date: Wed, 6 Jul 2005 10:54:49 -0400
>    From: Bob Rossi <bob@brasko.net>
> 
>    On Sun, Jul 03, 2005 at 02:43:25PM -0400, Daniel Jacobowitz wrote:
>    > On Sat, Jun 18, 2005 at 08:29:21AM -0400, Bob Rossi wrote:
>    > > Index: gdb/ChangeLog
>    > > +	* fork-child.c (fork-inferior): Use accessor function for
>    > > +	inferior_io_terminal.
>    > > +	* infcmd.c (inferior_io_terminal): Make static.
>    > > +	(set_inferior_io_terminal): New function.
>    > > +	(get_inferior_io_terminal): Ditto.
>    > > +	(tty_command): Use accessor function.
>    > > +	(_initialize_infcmd): Add inferior_tty setshow variable.
>    > > +	(_initialize_infcmd): Remove tty command.
>    > > +	(_initialize_infcmd): Add a tty command that is an alias.
>    > > +	* inferior.h (set_inferior_io_terminal): New prototype.
>    > > +	(get_inferior_io_terminal): Ditto.
>    > > +	(new_tty_prefork): Add const qualifier to parameter.
>    > > +	* inflow.c (inferior_thisrun_terminal): Add const qualifier.
>    > > +	(new_tty_prefork): Add const qualifier to parameter.
>    > > +	* nto-procfs (procfs_create_inferior): Use accessor function.
>    > > +	(procfs_create_inferior): Add const qualifier to locals.
>    > > +	* win32-nat.c (child_create_inferior): Ditto.
>    > > +	* mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): New function.
>    > > +	(mi_cmd_inferior_tty_set): Ditto.
>    > > +	* mi/mi-cmds.c (mi_cmds): Add inferior-tty-set and inferior-tty-show
>    > > +	* mi/mi-cmds.h (mi_cmd_inferior_tty_set): Add prototype.
>    > > +	(mi_cmd_inferior_tty_show): Ditto.
>    > > 
>    > > Index: gdb/doc/ChangeLog
>    > > +	* gdb.texinfo (GDB/MI Miscellaneous Commands): Add -inferior-tty-set
>    > > +	and -inferior-tty-show.
>    > > +	(Input/Output): Document "set/show inferior-tty" and tty alias.
>    > > 
>    > > Index: gdb/testsuite/ChangeLog
>    > > +	* gdb.mi/mi-basics.exp (test_setshow_inferior_tty): Test MI tty
>    > > +	command.
>    > 
>    > This is almost completely OK now!  Two minor fixes:
> 
>    Thanks very much! Committed. Now the interesting patches are coming :)
> 
> Bob, please make sure there are no regressions from your patch before
> you check things in.  I now get:
> 
> FAIL: gdb.base/default.exp: tty
> FAIL: gdb.base/help.exp: help tty

This patch fixes both the regressions and breaks nothing else. 
OK to Commit?

2005-07-11  Bob Rossi  <bob@brasko.net>

        * gdb.base/default.exp (tty): Changed output of command.
        * gdb.base/help.exp (help tty): Ditto.

Thanks,
Bob Rossi


Index: gdb/testsuite/gdb.base/default.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
retrieving revision 1.17
diff -u -r1.17 default.exp
--- gdb/testsuite/gdb.base/default.exp	20 Mar 2003 14:45:50 -0000	1.17
+++ gdb/testsuite/gdb.base/default.exp	11 Jul 2005 21:21:16 -0000
@@ -754,7 +754,7 @@
 #test tbreak
 gdb_test "tbreak" "No default breakpoint address now." "tbreak"
 #test tty
-gdb_test "tty" "Argument required .terminal name for running target process.*" "tty"
+gdb_test "tty" "Argument required .filename to set it to\..*" "tty"
 #test until "u" abbreviation
 gdb_test "u" "The program is not running." "until \"u\" abbreviation"
 #test until
Index: gdb/testsuite/gdb.base/help.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/help.exp,v
retrieving revision 1.14
diff -u -r1.14 help.exp
--- gdb/testsuite/gdb.base/help.exp	20 Mar 2003 14:19:41 -0000	1.14
+++ gdb/testsuite/gdb.base/help.exp	11 Jul 2005 21:21:17 -0000
@@ -562,7 +562,7 @@
 # test help tbreak
 gdb_test "help tbreak" "Set a temporary breakpoint.*" "help tbreak"
 # test help tty
-gdb_test "help tty" "Set terminal for future runs of program being debugged\." "help tty"
+gdb_test "help tty" "Set terminal for future runs of program being debugged\.\[\r\n\]+Usage: set inferior-tty /dev/pts/1" "help tty"
 # test help until "u" abbreviation
 gdb_test "help u" "Execute until the program reaches a source line greater than the current\[\r\n\]+or a specified location \\(same args as break command\\) within the current frame\." "help until \"u\" abbreviation"
 # test help until