Re: mi tty commands

[Eli Zaretskii <eliz@gnu.org>]

> Date: Sun, 29 May 2005 10:26:33 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sources.redhat.com
> 
> On Sun, May 29, 2005 at 09:55:23AM +0300, Eli Zaretskii wrote:
> > > +Show terminal for future runs of program being debugged.
> > 
> > I think the ``future'' part should be removed from this sentence: what
> > this command outputs is the terminal used _now_ as well as in the
> > future.
> 
> That's not strictly true.  It is the terminal that will be used the
> next time we start the program; we don't know at this point whether
> it's currently in use or whether the user has changed it since we last
> started the program.

That's true, but while for "set" we _know_ the value will be used only
in the future, we don't know that for sure in the case of "show".  If
someone can come up with a better wording, I'll be glad to hear.  But
to say "show terminal for future runs" would be misleading, I think.

> > 	* nto-procfs.c (procfs_create_inferior)
> > 	* win32-nat.c (child_create_inferior): Use get_inferior_io_terminal.
> > 
> > Note how I used the explicit name of the function used, instead of
> > just "accessor function".
> 
> Did you mean:
> 	* nto-procfs.c (procfs_create_inferior): Use
> 	get_inferior_io_terminal.
> 	* win32-nat.c (child_create_inferior): Likewise.
> 
> ?

No, I meant what I wrote.

> I thought it was incorrect to have no colon and log message
> corresponding to a bullet.

AFAIK, it _is_ correct.