From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/DWARF] Set TYPE_FLAG_STUB for enum DIEs that are declarations only
Date: Sat, 05 Jan 2008 15:17:00 -0000 [thread overview]
Message-ID: <ud4sguwsu.fsf@gnu.org> (raw)
In-Reply-To: <20080105150514.GF5975@adacore.com> (message from Joel Brobecker on Sat, 5 Jan 2008 07:05:14 -0800)
> Date: Sat, 5 Jan 2008 07:05:14 -0800
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
>
> TYPE_FLAG_STUB and a non-zero DW_AT_declaration attribute are two
> ways of saying the same thing.
And this is supposed to be known to Joe Random Hacker reading the code
because ...? Should we assume that whoever reads dwarf2read.c is
necessarily a DWARF-2 expert?
> Are you sure you want a comment?
>
> /* If the type is a declaration, then the definition is not
> complete. Mark the type as a stub. */
>
> This comment is just repeating the code.
That's not the kind of comment I was suggesting. I meant some summary
of the long explanation you posted as a preamble to the patch, which
explained why debugging Ada programs needed that.
next prev parent reply other threads:[~2008-01-05 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 15:45 Joel Brobecker
2008-01-03 15:46 ` Joel Brobecker
2008-01-03 16:02 ` Daniel Jacobowitz
2008-01-03 17:38 ` Joel Brobecker
2008-01-05 12:33 ` Eli Zaretskii
2008-01-05 15:05 ` Joel Brobecker
2008-01-05 15:17 ` Eli Zaretskii [this message]
2008-01-05 15:37 ` Joel Brobecker
2008-01-08 5:57 ` Joel Brobecker
2008-01-08 20:25 ` Eli Zaretskii
2008-01-09 4:31 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ud4sguwsu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox