From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/DWARF] Set TYPE_FLAG_STUB for enum DIEs that are declarations only
Date: Sat, 05 Jan 2008 12:33:00 -0000 [thread overview]
Message-ID: <uwsqov4dw.fsf@gnu.org> (raw)
In-Reply-To: <20080103154055.GD582@adacore.com> (message from Joel Brobecker on Thu, 3 Jan 2008 07:40:55 -0800)
> Date: Thu, 3 Jan 2008 07:40:55 -0800
> From: Joel Brobecker <brobecker@adacore.com>
>
> --- dwarf2read.c (revision 59)
> +++ dwarf2read.c (revision 60)
> @@ -4237,6 +4237,9 @@ read_enumeration_type (struct die_info *
> TYPE_LENGTH (type) = 0;
> }
>
> + if (die_is_declaration (die, cu))
> + TYPE_FLAGS (type) |= TYPE_FLAG_STUB;
> +
I'd suggest a comment here to explain why we do this.
next prev parent reply other threads:[~2008-01-05 12:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 15:45 Joel Brobecker
2008-01-03 15:46 ` Joel Brobecker
2008-01-03 16:02 ` Daniel Jacobowitz
2008-01-03 17:38 ` Joel Brobecker
2008-01-05 12:33 ` Eli Zaretskii [this message]
2008-01-05 15:05 ` Joel Brobecker
2008-01-05 15:17 ` Eli Zaretskii
2008-01-05 15:37 ` Joel Brobecker
2008-01-08 5:57 ` Joel Brobecker
2008-01-08 20:25 ` Eli Zaretskii
2008-01-09 4:31 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uwsqov4dw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox