Re: [RFA/DWARF] Set TYPE_FLAG_STUB for enum DIEs that are declarations only

[Joel Brobecker <brobecker@adacore.com>]

Hi Eli,

> > That's not the kind of comment I was suggesting.  I meant some summary
> > of the long explanation you posted as a preamble to the patch, which
> > explained why debugging Ada programs needed that.
> 
> The preample was an introduction to an part of the Ada language, not
> a description of a problem.  The "stub" DIE is a routine concept,
> that we see all the time with C opaque types. In fact, any type
> can be incomplete.
> 
> But rather than arguing this ad vitam aeternam, here's a suggestion:

First of all, I have to apologize for writing this way to you.
I admit to being fustrated, but my fustration was not with you. it
was with myself, because I don't understand exactly what it is that
you'd like me to put in the comment.

I know this situation will happen again in the future because we
all have different conceptions of what necessary documentation is.
I will try to say it openly when I don't understand, so that you
can help me (please :).

Do you still think a comment should be added? If yes, is the comment
I suggested a step in the right direction?

>   /* Enumeration DIEs descriptions can be imcomplete.  In Ada, any
>      type can be declared as private in the package spec, and then
>      defined only inside the package body.  Such types are known as
>      Taft Amendment Types.  When another package uses such a type,
>      an incomplete DIE may be generated by the compiler.  */

-- 
Joel