Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/DWARF] Set TYPE_FLAG_STUB for enum DIEs that are declarations only
Date: Wed, 09 Jan 2008 04:31:00 -0000	[thread overview]
Message-ID: <20080109043047.GB21281@adacore.com> (raw)
In-Reply-To: <u1w8st698.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

> Yes, thanks.  All I wanted was some kind of reference to Ada and
> private type declaration.  Armed with these clues, an intelligent
> reader will find out the rest.

Great! I checked the following change in:

2008-01-08  Joel Brobecker  <brobecker@adacore.com>

        * dwarf2read.c (read_enumeration_type): Add comment.

Thanks,
-- 
Joel

[-- Attachment #2: dw2.diff --]
[-- Type: text/plain, Size: 790 bytes --]

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.247
diff -u -p -r1.247 dwarf2read.c
--- dwarf2read.c	3 Jan 2008 17:29:55 -0000	1.247
+++ dwarf2read.c	9 Jan 2008 04:26:35 -0000
@@ -4233,6 +4233,11 @@ read_enumeration_type (struct die_info *
       TYPE_LENGTH (type) = 0;
     }
 
+  /* The enumeration DIE can be incomplete.  In Ada, any type can be
+     declared as private in the package spec, and then defined only
+     inside the package body.  Such types are known as Taft Amendment
+     Types.  When another package uses such a type, an incomplete DIE
+     may be generated by the compiler.  */
   if (die_is_declaration (die, cu))
     TYPE_FLAGS (type) |= TYPE_FLAG_STUB;
 

      reply	other threads:[~2008-01-09  4:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03 15:45 Joel Brobecker
2008-01-03 15:46 ` Joel Brobecker
2008-01-03 16:02   ` Daniel Jacobowitz
2008-01-03 17:38     ` Joel Brobecker
2008-01-05 12:33   ` Eli Zaretskii
2008-01-05 15:05     ` Joel Brobecker
2008-01-05 15:17       ` Eli Zaretskii
2008-01-05 15:37         ` Joel Brobecker
2008-01-08  5:57           ` Joel Brobecker
2008-01-08 20:25             ` Eli Zaretskii
2008-01-09  4:31               ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080109043047.GB21281@adacore.com \
    --to=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox