From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8941 invoked by alias); 9 Jan 2008 04:31:25 -0000 Received: (qmail 8927 invoked by uid 22791); 9 Jan 2008 04:31:24 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 09 Jan 2008 04:30:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5DBDC2A9690; Tue, 8 Jan 2008 23:30:55 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yDjMEbBUixCm; Tue, 8 Jan 2008 23:30:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 88F5A2A9666; Tue, 8 Jan 2008 23:30:54 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 59774E7ACB; Tue, 8 Jan 2008 20:30:47 -0800 (PST) Date: Wed, 09 Jan 2008 04:31:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFA/DWARF] Set TYPE_FLAG_STUB for enum DIEs that are declarations only Message-ID: <20080109043047.GB21281@adacore.com> References: <20080103153952.GC582@adacore.com> <20080103154055.GD582@adacore.com> <20080105150514.GF5975@adacore.com> <20080105153709.GH5975@adacore.com> <20080108055714.GB11831@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="oyUTqETQ0mS9luUI" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00173.txt.bz2 --oyUTqETQ0mS9luUI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 344 > Yes, thanks. All I wanted was some kind of reference to Ada and > private type declaration. Armed with these clues, an intelligent > reader will find out the rest. Great! I checked the following change in: 2008-01-08 Joel Brobecker * dwarf2read.c (read_enumeration_type): Add comment. Thanks, -- Joel --oyUTqETQ0mS9luUI Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="dw2.diff" Content-length: 790 Index: dwarf2read.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.247 diff -u -p -r1.247 dwarf2read.c --- dwarf2read.c 3 Jan 2008 17:29:55 -0000 1.247 +++ dwarf2read.c 9 Jan 2008 04:26:35 -0000 @@ -4233,6 +4233,11 @@ read_enumeration_type (struct die_info * TYPE_LENGTH (type) = 0; } + /* The enumeration DIE can be incomplete. In Ada, any type can be + declared as private in the package spec, and then defined only + inside the package body. Such types are known as Taft Amendment + Types. When another package uses such a type, an incomplete DIE + may be generated by the compiler. */ if (die_is_declaration (die, cu)) TYPE_FLAGS (type) |= TYPE_FLAG_STUB; --oyUTqETQ0mS9luUI--