From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17444 invoked by alias); 8 Jan 2008 05:57:43 -0000 Received: (qmail 17435 invoked by uid 22791); 8 Jan 2008 05:57:42 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 08 Jan 2008 05:57:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 95ECB2A967F; Tue, 8 Jan 2008 00:57:22 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id r6ZhnH0TX8Gq; Tue, 8 Jan 2008 00:57:22 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BFBC42A967E; Tue, 8 Jan 2008 00:57:21 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 89DC7E7ACB; Mon, 7 Jan 2008 21:57:14 -0800 (PST) Date: Tue, 08 Jan 2008 05:57:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFA/DWARF] Set TYPE_FLAG_STUB for enum DIEs that are declarations only Message-ID: <20080108055714.GB11831@adacore.com> References: <20080103153952.GC582@adacore.com> <20080103154055.GD582@adacore.com> <20080105150514.GF5975@adacore.com> <20080105153709.GH5975@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080105153709.GH5975@adacore.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00123.txt.bz2 Hi Eli, > > That's not the kind of comment I was suggesting. I meant some summary > > of the long explanation you posted as a preamble to the patch, which > > explained why debugging Ada programs needed that. > > The preample was an introduction to an part of the Ada language, not > a description of a problem. The "stub" DIE is a routine concept, > that we see all the time with C opaque types. In fact, any type > can be incomplete. > > But rather than arguing this ad vitam aeternam, here's a suggestion: First of all, I have to apologize for writing this way to you. I admit to being fustrated, but my fustration was not with you. it was with myself, because I don't understand exactly what it is that you'd like me to put in the comment. I know this situation will happen again in the future because we all have different conceptions of what necessary documentation is. I will try to say it openly when I don't understand, so that you can help me (please :). Do you still think a comment should be added? If yes, is the comment I suggested a step in the right direction? > /* Enumeration DIEs descriptions can be imcomplete. In Ada, any > type can be declared as private in the package spec, and then > defined only inside the package body. Such types are known as > Taft Amendment Types. When another package uses such a type, > an incomplete DIE may be generated by the compiler. */ -- Joel