From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26120 invoked by alias); 5 Jan 2008 15:17:22 -0000 Received: (qmail 26111 invoked by uid 22791); 5 Jan 2008 15:17:21 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 05 Jan 2008 15:17:02 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-71-78.inter.net.il [80.230.71.78]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id JUY57714 (AUTH halo1); Sat, 5 Jan 2008 17:16:41 +0200 (IST) Date: Sat, 05 Jan 2008 15:17:00 -0000 Message-Id: From: Eli Zaretskii To: Joel Brobecker CC: gdb-patches@sourceware.org In-reply-to: <20080105150514.GF5975@adacore.com> (message from Joel Brobecker on Sat, 5 Jan 2008 07:05:14 -0800) Subject: Re: [RFA/DWARF] Set TYPE_FLAG_STUB for enum DIEs that are declarations only Reply-to: Eli Zaretskii References: <20080103153952.GC582@adacore.com> <20080103154055.GD582@adacore.com> <20080105150514.GF5975@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00083.txt.bz2 > Date: Sat, 5 Jan 2008 07:05:14 -0800 > From: Joel Brobecker > Cc: gdb-patches@sourceware.org > > TYPE_FLAG_STUB and a non-zero DW_AT_declaration attribute are two > ways of saying the same thing. And this is supposed to be known to Joe Random Hacker reading the code because ...? Should we assume that whoever reads dwarf2read.c is necessarily a DWARF-2 expert? > Are you sure you want a comment? > > /* If the type is a declaration, then the definition is not > complete. Mark the type as a stub. */ > > This comment is just repeating the code. That's not the kind of comment I was suggesting. I meant some summary of the long explanation you posted as a preamble to the patch, which explained why debugging Ada programs needed that.