Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Frederic RISS <frederic.riss@st.com>
Cc: jimb@red-bean.com, gdb-patches@sourceware.org
Subject: Re: [RFC] Don't lose compilation directory in Dwarf2 line-tables
Date: Fri, 14 Apr 2006 08:44:00 -0000	[thread overview]
Message-ID: <u1ww035rv.fsf@gnu.org> (raw)
In-Reply-To: <1144999942.14807.721.camel@crx549.cro.st.com> (message from 	Frederic RISS on Fri, 14 Apr 2006 09:32:22 +0200)

> From: Frederic RISS <frederic.riss@st.com>
> Cc: GDB Patches <gdb-patches@sourceware.org>
> Date: Fri, 14 Apr 2006 09:32:22 +0200
> 
> On Thu, 2006-04-13 at 10:49 -0700, Jim Blandy wrote:
> > Hi, Frederic.  Thanks for the patch!  I think you're right about how
> > GDB should interpret DW_AT_comp_dir and directories in the line number
> > information.  Some comments:
> 
> Great.
> 
> > You should generally include a ChangeLog entry along with the patch;
> > you'll have to write it anyway, and it helps reviewers get oriented
> > for what they're going to see in the patch itself.
> 
> Will do for the next round.

Thanks.

In addition, I think the current algorithm for searching the sources
is described in the user's manual; please see if there's something in
that description that needs to be updated with your changes.


  parent reply	other threads:[~2006-04-14  8:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-13 11:25 [RFC] Don't loose " Frederic RISS
2006-04-13 17:49 ` Jim Blandy
2006-04-14  7:32   ` [RFC] Don't lose " Frederic RISS
2006-04-14  7:41     ` Jim Blandy
2006-04-14  8:23       ` Frederic RISS
2006-04-14 14:04         ` Daniel Jacobowitz
2006-04-14 14:51           ` Frederic RISS
2006-04-18 12:32             ` Frederic RISS
2006-04-18 13:04               ` Daniel Jacobowitz
2006-04-18 14:00                 ` Frederic RISS
2006-04-20 16:27                   ` Daniel Jacobowitz
2006-04-21  7:14                     ` Frederic RISS
2006-04-21  1:10                   ` Jim Blandy
2006-04-21  8:35                     ` Frederic RISS
2006-04-21 16:46                       ` Jim Blandy
2006-04-21 17:00                         ` Frederic RISS
2006-04-24 12:49                         ` Andrew STUBBS
2006-04-14  8:44     ` Eli Zaretskii [this message]
2006-04-14 11:44       ` Frederic RISS
2006-04-14 13:08         ` Eli Zaretskii
2006-04-14 13:42           ` Frederic RISS
2006-04-14 14:21             ` Eli Zaretskii
2006-04-14 14:58               ` Daniel Jacobowitz
2006-04-14 15:03                 ` Eli Zaretskii
2006-04-14 18:39               ` Frédéric Riss
2006-04-13 19:58 ` [RFC] Don't loose " Jason Molenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u1ww035rv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=frederic.riss@st.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jimb@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox