Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Frederic RISS <frederic.riss@st.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Jim Blandy <jimb@red-bean.com>, GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] Don't lose compilation directory in Dwarf2 line-tables
Date: Fri, 21 Apr 2006 07:14:00 -0000	[thread overview]
Message-ID: <1145603668.14807.1010.camel@crx549.cro.st.com> (raw)
In-Reply-To: <20060420162728.GG11710@nevyn.them.org>

On Thu, 2006-04-20 at 12:27 -0400, Daniel Jacobowitz wrote:
> On Tue, Apr 18, 2006 at 03:51:39PM +0200, Frederic RISS wrote:
> > +  if (dirname != NULL && dir != dirname)
> > +    xfree(dir);
> 
> xfree (dir) :-)

I've heard that patch reviewers have too much time and not enough work,
so I wouldn't dare to send a patch without something to comment :-)

Thanks again for the review.

> I've got no concerns about this patch; Jim was looking at this more
> than I was, though, so I hope he'll take a moment to look at this
> version.
> 


  reply	other threads:[~2006-04-21  7:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-13 11:25 [RFC] Don't loose " Frederic RISS
2006-04-13 17:49 ` Jim Blandy
2006-04-14  7:32   ` [RFC] Don't lose " Frederic RISS
2006-04-14  7:41     ` Jim Blandy
2006-04-14  8:23       ` Frederic RISS
2006-04-14 14:04         ` Daniel Jacobowitz
2006-04-14 14:51           ` Frederic RISS
2006-04-18 12:32             ` Frederic RISS
2006-04-18 13:04               ` Daniel Jacobowitz
2006-04-18 14:00                 ` Frederic RISS
2006-04-20 16:27                   ` Daniel Jacobowitz
2006-04-21  7:14                     ` Frederic RISS [this message]
2006-04-21  1:10                   ` Jim Blandy
2006-04-21  8:35                     ` Frederic RISS
2006-04-21 16:46                       ` Jim Blandy
2006-04-21 17:00                         ` Frederic RISS
2006-04-24 12:49                         ` Andrew STUBBS
2006-04-14  8:44     ` Eli Zaretskii
2006-04-14 11:44       ` Frederic RISS
2006-04-14 13:08         ` Eli Zaretskii
2006-04-14 13:42           ` Frederic RISS
2006-04-14 14:21             ` Eli Zaretskii
2006-04-14 14:58               ` Daniel Jacobowitz
2006-04-14 15:03                 ` Eli Zaretskii
2006-04-14 18:39               ` Frédéric Riss
2006-04-13 19:58 ` [RFC] Don't loose " Jason Molenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1145603668.14807.1010.camel@crx549.cro.st.com \
    --to=frederic.riss@st.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jimb@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox