From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17473 invoked by alias); 21 Apr 2006 07:14:47 -0000 Received: (qmail 17456 invoked by uid 22791); 21 Apr 2006 07:14:45 -0000 X-Spam-Check-By: sourceware.org Received: from fra-del-04.spheriq.net (HELO fra-del-04.spheriq.net) (195.46.51.100) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Apr 2006 07:14:42 +0000 Received: from fra-out-03.spheriq.net (fra-out-03.spheriq.net [195.46.51.131]) by fra-del-04.spheriq.net with ESMTP id k3L7Ed4Y005546 for ; Fri, 21 Apr 2006 07:14:39 GMT Received: from fra-cus-02.spheriq.net (fra-cus-02.spheriq.net [195.46.51.38]) by fra-out-03.spheriq.net with ESMTP id k3L7Ec4H031151 for ; Fri, 21 Apr 2006 07:14:39 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by fra-cus-02.spheriq.net with ESMTP id k3L7EZK8028799 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Fri, 21 Apr 2006 07:14:37 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 51CE9DA53; Fri, 21 Apr 2006 07:14:30 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id EAE0948754; Fri, 21 Apr 2006 07:14:29 +0000 (GMT) Received: from crx549.cro.st.com (crx549.cro.st.com [164.129.44.49]) by mail1.cro.st.com (MOS 3.5.8-GR) with ESMTP id CHF92321 (AUTH "frederic riss"); Fri, 21 Apr 2006 09:14:28 +0200 (CEST) Subject: Re: [RFC] Don't lose compilation directory in Dwarf2 line-tables From: Frederic RISS To: Daniel Jacobowitz Cc: Jim Blandy , GDB Patches In-Reply-To: <20060420162728.GG11710@nevyn.them.org> References: <1144927446.14807.561.camel@crx549.cro.st.com> <8f2776cb0604131049i69e9b20fv78e60c023f245e56@mail.gmail.com> <1144999942.14807.721.camel@crx549.cro.st.com> <8f2776cb0604140041o63c56c2xa9113d3c4ee259d@mail.gmail.com> <1145002976.14807.744.camel@crx549.cro.st.com> <20060414140449.GA14270@nevyn.them.org> <1145026289.14807.816.camel@crx549.cro.st.com> <1145363529.14807.848.camel@crx549.cro.st.com> <20060418130432.GC10130@nevyn.them.org> <1145368299.14807.889.camel@crx549.cro.st.com> <20060420162728.GG11710@nevyn.them.org> Content-Type: text/plain Date: Fri, 21 Apr 2006 07:14:00 -0000 Message-Id: <1145603668.14807.1010.camel@crx549.cro.st.com> Mime-Version: 1.0 X-Mailer: Evolution 2.6.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00308.txt.bz2 On Thu, 2006-04-20 at 12:27 -0400, Daniel Jacobowitz wrote: > On Tue, Apr 18, 2006 at 03:51:39PM +0200, Frederic RISS wrote: > > + if (dirname != NULL && dir != dirname) > > + xfree(dir); > > xfree (dir) :-) I've heard that patch reviewers have too much time and not enough work, so I wouldn't dare to send a patch without something to comment :-) Thanks again for the review. > I've got no concerns about this patch; Jim was looking at this more > than I was, though, so I hope he'll take a moment to look at this > version. >